Page MenuHomePhabricator
Create Task
Maniphest T174035

Allow the view action to show multiple slots [MCR]
Closed, ResolvedPublic
Actions

Description

When viewing a wiki page (revision), the content of all slots should be shown.

See https://www.mediawiki.org/wiki/Multi-Content_Revisions/Views#View_Action for notes.

NOTE: this is not a hard blocker for SDC General, since WikibaseMediaInfo already shows structured content on the file page using a hook. Using a generic mechanism would be better though, especially since it would make use of the ParserCache.

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+120 -17Make RefreshLinksJob MCR compliant.
mediawiki/coremaster+301 -77Deprecate methods in Article that delegate to WikiPage
mediawiki/coremaster+671 -172Use RevisionRenderer for rendering ParserOutput
mediawiki/coremaster+290 -133Cover incomplete revision case in RenderedRevision.
mediawiki/coremaster+164 -108Apply content wrapping in ParserOutput::getText()
mediawiki/coremaster+509 -8Add tests for article viewing
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
ResolveddanielT174036 Diffs page should show diffs and content from multiple slots [MCR]
OpenNoneT200572 Make ApiParse API module aware of MCR
ResolveddanielT174035 Allow the view action to show multiple slots [MCR]
ResolveddanielT194048 Introduce RevisionRenderer (baseline)
· · ·

Event Timeline

daniel created this task.Aug 24 2017, 2:45 PM
daniel created subtask T174036: Diffs page should show diffs and content from multiple slots [MCR].
daniel removed a project: Epic.Aug 24 2017, 2:48 PM
CCicalese_WMF moved this task from Inbox to MWPT-Q3-Jan-Mar-2018 on the MediaWiki-Platform-Team board.Oct 13 2017, 9:06 PM
CCicalese_WMF edited projects, added MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018); removed MediaWiki-Platform-Team.
daniel added a project: Multi-Content-Revisions.Nov 20 2017, 7:37 PM
daniel moved this task from Inbox to Epic on the Multi-Content-Revisions board.Nov 20 2017, 7:40 PM
thiemowmde triaged this task as Medium priority.Dec 5 2017, 6:45 PM
Lydia_Pintscher moved this task from incoming to monitoring on the Wikidata board.Dec 18 2017, 3:12 PM
CCicalese_WMF moved this task from MWPT-Q3-Jan-Mar-2018 to MWPT-Q4-Apr-Jun-2018 on the MediaWiki-Platform-Team board.Jan 2 2018, 4:08 PM
CCicalese_WMF edited projects, added MediaWiki-Platform-Team (MWPT-Q4-Apr-Jun-2018); removed MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018).
Anomie mentioned this in T174032: Make relevant API modules aware of MCR.Feb 21 2018, 6:43 PM
gerritbot added a subscriber: gerritbot.Mar 8 2018, 7:03 PM

Change 387685 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Deprecate methods in Article that delegate to WikiPage

https://gerrit.wikimedia.org/r/387685

gerritbot added a project: Patch-For-Review.Mar 8 2018, 7:03 PM
daniel updated the task description. (Show Details)Mar 15 2018, 6:15 PM
CCicalese_WMF moved this task from Ready to Watching on the MediaWiki-Platform-Team (MWPT-Q4-Apr-Jun-2018) board.Apr 4 2018, 6:50 PM
CCicalese_WMF removed a subtask: T174036: Diffs page should show diffs and content from multiple slots [MCR].Apr 19 2018, 5:10 PM
CCicalese_WMF added a parent task: T174036: Diffs page should show diffs and content from multiple slots [MCR].
gerritbot added a comment.Apr 26 2018, 4:59 PM

Change 421794 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] [MCR][WIP] Intropduce RevisionRenderer

https://gerrit.wikimedia.org/r/421794

Tgr claimed this task.Apr 26 2018, 5:02 PM
daniel moved this task from Epic to Inbox on the Multi-Content-Revisions board.May 7 2018, 10:48 AM
daniel moved this task from Inbox to Declined/Invalid on the Multi-Content-Revisions board.May 7 2018, 10:51 AM
daniel moved this task from Declined/Invalid to Epic on the Multi-Content-Revisions board.May 7 2018, 3:09 PM
CCicalese_WMF moved this task from Epic to MCR-SDC Storage Layer - phase 1 on the Multi-Content-Revisions board.May 8 2018, 1:08 PM
CCicalese_WMF edited projects, added Multi-Content-Revisions (MCR-SDC Storage Layer - phase 1); removed Multi-Content-Revisions.
CCicalese_WMF moved this task from Backlog to In Progress on the Multi-Content-Revisions (MCR-SDC Storage Layer - phase 1) board.May 8 2018, 1:12 PM
daniel updated the task description. (Show Details)May 15 2018, 9:15 AM
daniel mentioned this in T174036: Diffs page should show diffs and content from multiple slots [MCR].May 15 2018, 9:17 AM
CCicalese_WMF moved this task from In Progress to Backlog on the Multi-Content-Revisions (MCR-SDC Storage Layer - phase 1) board.May 15 2018, 3:12 PM
CCicalese_WMF removed a parent task: T174022: Implement multi-content revisions.May 31 2018, 2:58 AM
CCicalese_WMF edited projects, added Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2); removed Multi-Content-Revisions (MCR-SDC Storage Layer - phase 1).May 31 2018, 5:14 PM
daniel moved this task from Backlog to In Progress on the Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2) board.Jul 9 2018, 4:14 PM
CCicalese_WMF removed a project: MediaWiki-Platform-Team (MWPT-Q4-Apr-Jun-2018).Jul 11 2018, 9:29 PM
CCicalese_WMF mentioned this in T200572: Make ApiParse API module aware of MCR.Jul 27 2018, 10:03 PM
CCicalese_WMF added a parent task: T200572: Make ApiParse API module aware of MCR.
daniel moved this task from In Progress to Blocked on the Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2) board.Aug 3 2018, 11:32 AM
daniel claimed this task.Aug 14 2018, 12:08 PM
daniel added a subscriber: Tgr.
daniel moved this task from Blocked to In Progress on the Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2) board.Aug 14 2018, 4:38 PM
gerritbot added a comment.Aug 14 2018, 4:39 PM

Change 452708 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Use RevisionRenderer for rendering ParserOutput

https://gerrit.wikimedia.org/r/452708

daniel added a comment.Aug 14 2018, 4:51 PM

This is work in progress, but here's a first screenshot!

Bildschirmfoto vom 2018-08-14 18-40-25.png (496×867 px, 67 KB)

gerritbot added a comment.Aug 16 2018, 7:09 PM

Change 453190 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Add tests for article viewing

https://gerrit.wikimedia.org/r/453190

daniel moved this task from In Progress to Needs Review on the Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2) board.Aug 20 2018, 7:57 PM
gerritbot added a comment.Aug 28 2018, 4:49 PM

Change 455865 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Apply content wrapping in ParserOutput::getText()

https://gerrit.wikimedia.org/r/455865

gerritbot added a comment.Aug 29 2018, 3:29 PM

Change 453190 merged by jenkins-bot:
[mediawiki/core@master] Add tests for article viewing

https://gerrit.wikimedia.org/r/453190

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)).Aug 29 2018, 4:00 PM
gerritbot added a comment.Aug 29 2018, 4:25 PM

Change 455865 merged by jenkins-bot:
[mediawiki/core@master] Apply content wrapping in ParserOutput::getText()

https://gerrit.wikimedia.org/r/455865

Tgr closed subtask T194048: Introduce RevisionRenderer (baseline) as Resolved.Aug 31 2018, 11:33 AM
gerritbot added a comment.Sep 3 2018, 1:37 PM

Change 457450 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Cover incomplete revision case in RenderedRevision.

https://gerrit.wikimedia.org/r/457450

gerritbot added a comment.Sep 7 2018, 10:48 AM

Change 458526 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Require a Title as context for rendering.

https://gerrit.wikimedia.org/r/458526

gerritbot added a comment.Sep 11 2018, 4:18 PM

Change 457450 merged by jenkins-bot:
[mediawiki/core@master] Cover incomplete revision case in RenderedRevision.

https://gerrit.wikimedia.org/r/457450

gerritbot added a comment.Sep 11 2018, 4:33 PM

Change 452708 merged by jenkins-bot:
[mediawiki/core@master] Use RevisionRenderer for rendering ParserOutput

https://gerrit.wikimedia.org/r/452708

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)); removed MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)).Sep 11 2018, 5:01 PM
daniel closed this task as Resolved.Sep 12 2018, 11:04 AM
daniel moved this task from Needs Review to Done on the Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2) board.
Krinkle mentioned this in T203805: codesniffer detects unparenthesized ternary in mediawiki/core Article.php.Sep 16 2018, 3:53 PM
daniel reopened this task as Open.Oct 8 2018, 12:31 PM
daniel raised the priority of this task from Medium to High.

Re-opening, since we missed the fact that RefreshLinksJob will only re-render the main slot, and then place the ParserOutput for only the main slot into the parser cache. We need to survey all code paths that re-render and cache ParserOutput to avoid this problem.

Setting prio to high, since this blocks SDC deployment.

gerritbot added a comment.Oct 8 2018, 2:02 PM

Change 465157 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Make RefreshLinksJob MCR compliant.

https://gerrit.wikimedia.org/r/465157

gerritbot added a comment.Oct 9 2018, 2:28 AM

Change 465157 merged by jenkins-bot:
[mediawiki/core@master] Make RefreshLinksJob MCR compliant.

https://gerrit.wikimedia.org/r/465157

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)); removed MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)).Oct 9 2018, 3:00 AM
Tgr closed this task as Resolved.Oct 9 2018, 3:14 AM
gerritbot added a comment.Oct 22 2018, 4:24 PM

Change 469025 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Follow-up T174035: Wrap inline ternary in brackets to make phpcs happy

https://gerrit.wikimedia.org/r/469025

gerritbot added a comment.Oct 22 2018, 4:47 PM

Change 469025 merged by jenkins-bot:
[mediawiki/core@master] Follow-up T174035: Wrap inline ternary in brackets to make phpcs happy

https://gerrit.wikimedia.org/r/469025

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL