Page MenuHomePhabricator
Create Task
Maniphest T174100

Watchlist: watchlistactivity=seen does not display seen changes
Closed, DuplicatePublic
Actions

Description

Checked in betalabs and in the current production (wmf.15) using rcfilters=1 in a url.

  1. Go to the Watchlist with filters. Make sure that you have some seen changes displayed ('Mark all changes as seen' button should be inactive). Or just click on the button to make all changes seen.
  2. Click to select both 'Seen changes' and 'Unseen changes' filters (full coverage) - some records should be displayed.
  3. Deselect 'Unseen changes' - no changes will be displayed.
  4. Deselect 'Seen changes' - changes will be shown.

Related Objects

Event Timeline

Etonkovidova created this task.Aug 24 2017, 9:01 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 24 2017, 9:01 PM
Etonkovidova mentioned this in T171121: Rename 'Mark all pages as Visited" button to "Mark all changes as Seen" and put in the new UI style.Aug 24 2017, 9:16 PM
• jmatazzoni subscribed.Aug 24 2017, 9:22 PM

@Etonkovidova, is this ticket a duplicate of T171127? If not, what is distinct?

Etonkovidova added a comment.Aug 24 2017, 9:26 PM

@jmatazzoni 'Seen changes' filter never shows any changes - which is a bug.

T171127: Adapt 'Watchlisted pages' filter group (or create similar one) for Watchlist is a general ticket about overall functionality of Watchlist filters, e.g. how 'Seen changes' filter is supposed to work.

A new filter is added, "Seen changes". This filter identifies all changes to pages the user has not visited since the changes occurred.

• jmatazzoni added a comment.Aug 24 2017, 9:30 PM

! In T174100#3551012, @Etonkovidova wrote:

T171127: Adapt 'Watchlisted pages' filter group (or create similar one) for Watchlist is a general ticket about overall functionality of Watchlist filters, e.g. how 'Seen changes' filter is supposed to work.

A new filter is added, "Seen changes". This filter identifies all changes to pages the user has not visited since the changes occurred.

Right. That's why this seems like a dupe. Because you can't certify that T171127 is OK until the Seen Changes filters that are a key part of that ticket work. I'd rather close this ticket and just report that seen changes doesn't work in T171127. OK with you?

Etonkovidova added a comment.Aug 24 2017, 9:46 PM

@jmatazzoni I used url stuff when I was checking. I mentioned it in the ticket specifically in case the issue is happening because of testing limitations.

SBisson closed this task as a duplicate of T171127: Adapt 'Watchlisted pages' filter group (or create similar one) for Watchlist .Aug 25 2017, 12:55 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL