Page MenuHomePhabricator

When edited, Flow system message 'Flow-terms-of-use-edit' displays raw text.
Open, Needs TriagePublic

Description

Version: 1.29 (REL1_29)
PHP: 5.6

After trying to edit the MediaWiki:Flow-terms-of-use-edit page, and adding an HTML tag (i.e. <big>text</big>) said tag does not work, and when navigating to the page where the system message is, the tags just show up as, so "<big>text</big>" and are not taken into account.

Tests done on test.wiki do the following:

  • Add HTML markip displays the text and the HTML markup: <h3>By saving your changes, you agree to the [[terms of use]] for this wiki.</h3>
  • Add wikitext markip displays the text and the wikitext markup : '''By saving your changes, you agree to the [[terms of use]] for this wiki.'''

HTML tags work with normal MediaWiki system messages, as well as with other extensions.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

On which wiki have you done that change?

Also note that standard wiki-markup such as ''' for bold also doesn't work, only wiki links ([[Page]]) work.

Ok, thanks!

@Etonkovidova, can you have a look at it? I can't test on test wiki.

@Trizek-WMF I asked @AlvaroMolina since they are an administrator there, and they have edited the page on test.wikipedia.org, see https://test.wikipedia.org/wiki/MediaWiki:Flow-terms-of-use-edit.

Thanks! The result is <h3>By saving your changes, you agree to the [[terms of use]] for this wiki.</h3>

Capture d’écran_2017-08-25_16-21-52.png (490×598 px, 83 KB)

Trizek-WMF renamed this task from Editing Flow system message 'Flow-terms-of-use-edit' does not work to Editing Flow system message 'Flow-terms-of-use-edit' displays raw HTML.Aug 25 2017, 2:22 PM

@Trizek-WMF: I have given you the administrator permission in Test Wikipedia so that you can work more comfortably with the resolution of this task.

@Trizek-WMF: I have given you the administrator permission in Test Wikipedia so that you can work more comfortably with the resolution of this task.

Sweet! Thanks @AlvaroMolina.

I4ve changes <h3> to bolded wikitext, but it doesn't work.

Trizek-WMF renamed this task from Editing Flow system message 'Flow-terms-of-use-edit' displays raw HTML to When edited, Flow system message 'Flow-terms-of-use-edit' displays raw text..Aug 25 2017, 2:36 PM
Trizek-WMF updated the task description. (Show Details)

I checked the issue in betalabs - yes, the markup will be displayed. When it's debatable whether or not the formatted text should be present in such elements, markup tags should be either filtered or detected upon saving the edits and not saved.

It is present for generic MediaWiki system messages and other extensions, so I don't see why it shouldn't also be the case for Flow.