Page MenuHomePhabricator

Display user account blocks in mobile view on Special:Contributions
Open, MediumPublic

Description

Background

Here is an example of a Wikipedia IP account with a block.
https://en.wikipedia.org/wiki/Special:Contributions/207.63.57.114
The user was a vandal. Now they are blocked.

Here is the mobile view of that same account.
https://en.m.wikipedia.org/wiki/Special:Contributions/207.63.57.114
The fact of the block is not displayed. Consequently, users in mobile may request blocks not knowing that the matter is resolved.

Acceptance criteria

  • Add blocked account information to special:contributions page on mobile

Event Timeline

Restricted Application added subscribers: jeblad, Aklapper. · View Herald TranscriptAug 25 2017, 7:01 PM
jeblad removed a subscriber: jeblad.Aug 25 2017, 9:18 PM
Aklapper renamed this task from user account blocks fail to display in mobile view to User account blocks fail to display in mobile view on Special:Contributions.Aug 26 2017, 11:28 AM
Aklapper edited projects, added MobileFrontend, MediaWiki-Special-pages; removed Mobile.
ovasileva triaged this task as Medium priority.Aug 28 2017, 12:21 PM
ovasileva renamed this task from User account blocks fail to display in mobile view on Special:Contributions to Display user account blocks in mobile view on Special:Contributions.Aug 28 2017, 12:23 PM
ovasileva updated the task description. (Show Details)
Jdlrobson added a subscriber: Jdlrobson.

Long term we want to get rid of the mobile version of the page, but Special:Contributions is going to need a huge rewrite for that to happen and I don't know how we make that happen right now (Community wishlist would be a good place to voice this - see related card for watchlist - T109277).

Change 499864 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Remove the SpecialMobile(History|Contributions) page and use the core versions

https://gerrit.wikimedia.org/r/499864

Change 499864 abandoned by Jdlrobson:
Remove the SpecialMobile(Watchlist|History|Contributions) page and use the core versions

https://gerrit.wikimedia.org/r/499864

I think it's trivial to fix this. :-).

Let's be careful about making too many changes to the mobile contributions page. This code really should not exist anymore and I'd rather see a move towards the version inside consolidating this code with the one in Advanced Mobile contribution mode.

FYI, I might also be the only code reviewer who is reasonably comfortable with this code and I personally cannot invest any further time in code review for it right now so you'll probably want to identify a reviewer before spending time working on this and other related patches.

I see. Some of these issues have been lingering for close to four years and more are being filed e.g T265402, T233845, so I thought it'd be good to fix them, I see that's not the case now and that's fine.

I didn't wrote anything actually, but from mental modelling I didn't think it's complicated either as the comment in T174194#3558876 suggested. But since the complete switch to the core versions is preferred, that's fine too.

It would be good to fix them as this is clearly not happening any time soon, I just don't have the capacity to do so. If you can find someone upfront willing to do code review then that's fine with me, I just don't want to feel obliged to code review when nobody else is for the good of my own mental health :).