Page MenuHomePhabricator

Get rid of the non-Tidy option in parser tests
Closed, ResolvedPublic

Description

There's no reason to run parser tests without Tidy. All deployments do Remex tidying now. The non-tidied option just adds to testing bloat and introduces newer test modes and edge cases that are not significant wrt production uses.

Further, parserTests are the last places which use the "no tidy" paths in the core parser, which need to be cleaned up/removed.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/TEIREL1_35+10 -2
mediawiki/extensions/NaturalLanguageListmaster+86 -84
mediawiki/extensions/TEImaster+10 -2
mediawiki/coremaster+4 -0
mediawiki/extensions/PhpTagsFunctionsmaster+14 -12
mediawiki/extensions/PhpTagsmaster+38 -36
mediawiki/extensions/PhpTagsWidgetsmaster+98 -96
mediawiki/extensions/PhpTagsWikimaster+30 -26
mediawiki/extensions/ProofreadPagemaster+82 -78
mediawiki/extensions/Variablesmaster+28 -26
mediawiki/extensions/LabeledSectionTransclusionmaster+270 -264
mediawiki/extensions/intersectionmaster+119 -138
mediawiki/extensions/wikihieromaster+33 -31
mediawiki/extensions/Mathmaster+4 -2
mediawiki/extensions/Calendarmaster+18 -20
mediawiki/extensions/SoftRedirectormaster+9 -5
mediawiki/extensions/Graphmaster+6 -4
mediawiki/extensions/SecureLinkFixermaster+4 -2
mediawiki/extensions/Scribuntomaster+63 -57
mediawiki/extensions/DateDiffmaster+5 -3
mediawiki/extensions/RegexFunmaster+75 -74
mediawiki/extensions/WikiSEOmaster+2 -0
mediawiki/extensions/Josamaster+134 -132
mediawiki/extensions/CharInsertmaster+9 -6
mediawiki/extensions/CharRangeSpanmaster+26 -24
mediawiki/extensions/Kartographermaster+59 -53
mediawiki/extensions/Arraysmaster+153 -151
mediawiki/extensions/ReplaceSetmaster+8 -6
mediawiki/extensions/SyntaxHighlight_GeSHimaster+28 -26
mediawiki/extensions/Disambiguatormaster+4 -2
mediawiki/coremaster+0 -4
mediawiki/coremaster+4 -0
mediawiki/coremaster+0 -0
mediawiki/coremaster+403 -436
mediawiki/coremaster+81 -43
Show related patches Customize query in gerrit

Related Objects

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
cscott renamed this task from Investigate getting rid of the non-Tidy option in parser tests to Get rid of the non-Tidy option in parser tests.Feb 26 2020, 8:08 PM
cscott updated the task description. (Show Details)

Change 585253 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] WIP: deprecate parserTests format v1 (untidy by default)

https://gerrit.wikimedia.org/r/585253

Change 585273 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Update extraParserTests.txt to parserTests v2 (tidy by default)

https://gerrit.wikimedia.org/r/585273

Change 585273 merged by jenkins-bot:
[mediawiki/core@master] Update extraParserTests.txt to parserTests v2 (tidy by default)

https://gerrit.wikimedia.org/r/585273

Change 585253 merged by jenkins-bot:
[mediawiki/core@master] Deprecate parserTests format v1

https://gerrit.wikimedia.org/r/585253

Change 585429 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Revert "Deprecate parserTests format v1"

https://gerrit.wikimedia.org/r/585429

Change 585429 merged by jenkins-bot:
[mediawiki/core@master] Revert "Deprecate parserTests format v1"

https://gerrit.wikimedia.org/r/585429

Change 585546 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Update parserTests to v2 (tidy by default)

https://gerrit.wikimedia.org/r/585546

Change 585548 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/Kartographer@master] Update parserTests to v2 (tidy by default)

https://gerrit.wikimedia.org/r/585548

Change 585549 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/Scribunto@master] Update parserTests to v2 (tidy by default)

https://gerrit.wikimedia.org/r/585549

Change 585550 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/Disambiguator@master] Update to parserTests v2 (tidy by default)

https://gerrit.wikimedia.org/r/585550

Change 585550 merged by jenkins-bot:
[mediawiki/extensions/Disambiguator@master] Update to parserTests v2 (tidy by default)

https://gerrit.wikimedia.org/r/585550

Change 585546 merged by jenkins-bot:
[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Update parserTests to v2 (tidy by default)

https://gerrit.wikimedia.org/r/585546

Change 585556 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Deprecate parserTests format v1 (take 2)

https://gerrit.wikimedia.org/r/585556

Change 585557 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/SoftRedirector@master] Update to parserTests v2 (tidy by default)

https://gerrit.wikimedia.org/r/585557

Change 585558 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/SecureLinkFixer@master] Update to parserTests v2 (tidy by default)

https://gerrit.wikimedia.org/r/585558

Change 585559 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/CharRangeSpan@master] Update to parserTests v2 (tidy by default)

https://gerrit.wikimedia.org/r/585559

Change 585560 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/ReplaceSet@master] Update to parserTests v2 (tidy by default)

https://gerrit.wikimedia.org/r/585560

Change 585561 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/Arrays@master] Update to parserTests v2 (tidy by default)

https://gerrit.wikimedia.org/r/585561

Change 585548 merged by jenkins-bot:
[mediawiki/extensions/Kartographer@master] Update parserTests to v2 (tidy by default)

https://gerrit.wikimedia.org/r/585548

Change 585549 merged by jenkins-bot:
[mediawiki/extensions/Scribunto@master] Update parserTests to v2 (tidy by default)

https://gerrit.wikimedia.org/r/585549

Change 585563 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/RegexFun@master] Update to parserTests v2 (tidy by default)

https://gerrit.wikimedia.org/r/585563

Change 585564 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/Graph@master] Update to parserTests v2 (tidy by default)

https://gerrit.wikimedia.org/r/585564

Change 585565 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/DateDiff@master] Update to parserTests v2 (tidy by default)

https://gerrit.wikimedia.org/r/585565

Change 585560 merged by jenkins-bot:
[mediawiki/extensions/ReplaceSet@master] Update to parserTests v2 (tidy by default)

https://gerrit.wikimedia.org/r/585560

Change 585558 merged by jenkins-bot:
[mediawiki/extensions/SecureLinkFixer@master] Update to parserTests v2 (tidy by default)

https://gerrit.wikimedia.org/r/585558

Change 585567 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/Calendar@master] Update to parserTests v2 (tidy by default)

https://gerrit.wikimedia.org/r/585567

Change 585568 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/Math@master] Update to parserTests v2 (tidy by default)

https://gerrit.wikimedia.org/r/585568

Change 585569 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/NaturalLanguageList@master] Update to parserTests v2 (tidy by default)

https://gerrit.wikimedia.org/r/585569

Change 585570 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/CharInsert@master] Update to parserTests v2 (tidy by default)

https://gerrit.wikimedia.org/r/585570

Change 585571 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/Josa@master] Update to parserTests v2 (tidy by default)

https://gerrit.wikimedia.org/r/585571

Change 585572 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/WikiSEO@master] Update to parserTests v2 (tidy by default)

https://gerrit.wikimedia.org/r/585572

Change 585561 merged by jenkins-bot:
[mediawiki/extensions/Arrays@master] Update to parserTests v2 (tidy by default)

https://gerrit.wikimedia.org/r/585561

Change 585564 merged by jenkins-bot:
[mediawiki/extensions/Graph@master] Update to parserTests v2 (tidy by default)

https://gerrit.wikimedia.org/r/585564

Change 585559 merged by jenkins-bot:
[mediawiki/extensions/CharRangeSpan@master] Update to parserTests v2 (tidy by default)

https://gerrit.wikimedia.org/r/585559

Change 585570 merged by jenkins-bot:
[mediawiki/extensions/CharInsert@master] Update to parserTests v2 (tidy by default)

https://gerrit.wikimedia.org/r/585570

Change 585571 merged by jenkins-bot:
[mediawiki/extensions/Josa@master] Update to parserTests v2 (tidy by default)

https://gerrit.wikimedia.org/r/585571

Change 585572 merged by jenkins-bot:
[mediawiki/extensions/WikiSEO@master] Update to parserTests v2 (tidy by default)

https://gerrit.wikimedia.org/r/585572

Change 585563 merged by jenkins-bot:
[mediawiki/extensions/RegexFun@master] Update to parserTests v2 (tidy by default)

https://gerrit.wikimedia.org/r/585563

Change 585565 merged by jenkins-bot:
[mediawiki/extensions/DateDiff@master] Update to parserTests v2 (tidy by default)

https://gerrit.wikimedia.org/r/585565

Change 585567 merged by jenkins-bot:
[mediawiki/extensions/Calendar@master] Update to parserTests v2 (tidy by default)

https://gerrit.wikimedia.org/r/585567

Change 585568 merged by jenkins-bot:
[mediawiki/extensions/Math@master] Update to parserTests v2 (tidy by default)

https://gerrit.wikimedia.org/r/585568

Change 585588 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/LabeledSectionTransclusion@master] Update to parserTests v2 (tidy by default)

https://gerrit.wikimedia.org/r/585588

Change 585589 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/PhpTags@master] Update to parserTests v2 (tidy by default)

https://gerrit.wikimedia.org/r/585589

Change 585590 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/ProofreadPage@master] Update to parserTests v2 (tidy by default)

https://gerrit.wikimedia.org/r/585590

Change 585591 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/intersection@master] Update to parserTests v2 (tidy by default)

https://gerrit.wikimedia.org/r/585591

Change 585592 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/wikihiero@master] Update to parserTests v2 (tidy by default)

https://gerrit.wikimedia.org/r/585592

Change 585593 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/Variables@master] Update to parserTests v2 (tidy by default)

https://gerrit.wikimedia.org/r/585593

Change 585594 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/PhpTagsFunctions@master] Update to parserTests v2 (tidy by default)

https://gerrit.wikimedia.org/r/585594

Change 585596 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/PhpTagsWidgets@master] Update to parserTests v2 (tidy by default)

https://gerrit.wikimedia.org/r/585596

Change 585597 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/PhpTagsWiki@master] Update to parserTests v2 (tidy by default)

https://gerrit.wikimedia.org/r/585597

Change 585592 merged by jenkins-bot:
[mediawiki/extensions/wikihiero@master] Update to parserTests v2 (tidy by default)

https://gerrit.wikimedia.org/r/585592

Change 585591 merged by jenkins-bot:
[mediawiki/extensions/intersection@master] Update to parserTests v2 (tidy by default)

https://gerrit.wikimedia.org/r/585591

Change 585588 merged by jenkins-bot:
[mediawiki/extensions/LabeledSectionTransclusion@master] Update to parserTests v2 (tidy by default)

https://gerrit.wikimedia.org/r/585588

Change 585590 merged by jenkins-bot:
[mediawiki/extensions/ProofreadPage@master] Update to parserTests v2 (tidy by default)

https://gerrit.wikimedia.org/r/585590

Change 585593 merged by jenkins-bot:
[mediawiki/extensions/Variables@master] Update to parserTests v2 (tidy by default)

https://gerrit.wikimedia.org/r/585593

Change 585556 merged by jenkins-bot:
[mediawiki/core@master] Deprecate parserTests format v1 (take 2)

https://gerrit.wikimedia.org/r/585556

Change 585597 merged by Umherirrender:
[mediawiki/extensions/PhpTagsWiki@master] Update to parserTests v2 (tidy by default)

https://gerrit.wikimedia.org/r/585597

Change 585596 merged by Umherirrender:
[mediawiki/extensions/PhpTagsWidgets@master] Update to parserTests v2 (tidy by default)

https://gerrit.wikimedia.org/r/585596

Change 585589 merged by Umherirrender:
[mediawiki/extensions/PhpTags@master] Update to parserTests v2 (tidy by default)

https://gerrit.wikimedia.org/r/585589

Change 585594 merged by Umherirrender:
[mediawiki/extensions/PhpTagsFunctions@master] Update to parserTests v2 (tidy by default)

https://gerrit.wikimedia.org/r/585594

cscott claimed this task.

As of 83a22b7fcde35954461356d4e3859647f45f9cba we no longer run untidy parser tests.

Change 620765 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/TEI@master] Update parser tests files to version 2

https://gerrit.wikimedia.org/r/620765

Change 620765 merged by jenkins-bot:
[mediawiki/extensions/TEI@master] Update parser tests files to version 2

https://gerrit.wikimedia.org/r/620765

Change 585569 merged by C. Scott Ananian:
[mediawiki/extensions/NaturalLanguageList@master] Update to parserTests v2 (tidy by default)

https://gerrit.wikimedia.org/r/585569

Change 690824 had a related patch set uploaded (by Umherirrender; author: C. Scott Ananian):

[mediawiki/extensions/TEI@REL1_35] Update parser tests files to version 2

https://gerrit.wikimedia.org/r/690824

Change 690824 merged by Umherirrender:

[mediawiki/extensions/TEI@REL1_35] Update parser tests files to version 2

https://gerrit.wikimedia.org/r/690824