I’m sometimes getting the JS-error
TypeError: data.options is undefined
from the module ext.wikimediaEvents.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Kartographer: Protect against undefined data.options | mediawiki/extensions/WikimediaEvents | master | +1 -1 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Declined | None | T174538 Relaunch Geohack mobile maps gadget experiment on English Wikipedia | |||
| Resolved | TheDJ | T173283 Extra 100KB of JS loaded by mobilemaps gadget on pageview | |||
| Resolved | pmiazga | T171180 Gadget with target=mobile should not be enqueued on desktop (Warning from mw.loader.load) | |||
| Resolved | phuedx | T213242 Move OutputPage::setTarget() call from BeforePageDisplay to an earlier hook | |||
| Declined | None | T173049 Investigate mobile map gadget for eventlogging | |||
| Resolved | debt | T174249 TypeError in ext.wikimediaEvents | |||
| Resolved | Jdlrobson | T173309 Mobile target cannot have a default enabled gadget for anonymous users |
Event Timeline
Comment Actions
Hi @Nenntmichruhigip - on which Wikimedia wiki is this happening? Is there anything in particular which normally causes this error (so we can reproduce it)? Where is this error shown?
Comment Actions
- This was on Commons, but I’m assuming it would also happen on other wikis.
- No, nothing in particular, reloading a few times "helped" (actually it took surprisingly many reloads), so it seems like an issue of execution order to me: Whatever defines data.options is normally executed first, but apparently not guaranteed to.
- In the error console of course :-) Unfortunatly such errors break all other JS on the page, so it’s quite annoying when it happens…
Comment Actions
Any chance to provide the console output (exact file name and location of file triggering this) with [[ https://www.mediawiki.org/wiki/Help:Locating_broken_scripts | &debug=true ]]? But if you cannot reproduce too often it's probably unlikely and cumbersome...
Comment Actions
Ah well, ignore that, there is only one line including that:
./modules/ext.wikimediaEvents.kartographer.js: options.extra.layer = data.options.extra.layer;
Comment Actions
Change 378516 had a related patch set uploaded (by TheDJ; owner: TheDJ):
[mediawiki/extensions/WikimediaEvents@master] Kartographer: Protect against undefined data.options
Comment Actions
Change 378516 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEvents@master] Kartographer: Protect against undefined data.options