Maniphest T174373

Extension:ArticleToCategory2 -- HTML comments are not valid JS
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	labster
	Aug 28 2017, 7:10 PM

Tags

Referenced Files

None

Subscribers

Description

At line 186 of ArticleToCategory2.php, this is the middle of a Javascript function:

		<!-- alert(.title.value); -->

This should be changed to js style comments /* ... */ or better yet removed entirely.

Revisions and Commits

rEATC extension-ArticleToCategory2
	rEATCaeabc5388709 Cleanup & rework

Related Objects

Mentioned In: rEATC38c25553779c: Update patch set 4
rEATCae7806f736b3: Update patch set 4

Event Timeline

labster created this task.Aug 28 2017, 7:10 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 28 2017, 7:10 PM

Pinging maintainer @MikaelLindmark

Reception123 mentioned this in rEATCae7806f736b3: Update patch set 4.Jun 11 2018, 6:20 PM

Mainframe98 mentioned this in rEATC38c25553779c: Update patch set 4.Jun 11 2018, 6:20 PM

Liuxinyu970226 unsubscribed.Sep 17 2018, 2:39 PM

Peachey88 edited projects, added MediaWiki-extensions-ArticleToCategory2; removed MediaWiki-extensions-Other.Jan 12 2020, 7:34 AM

ashley closed this task as Resolved by committing rEATCaeabc5388709: Cleanup & rework.Sep 4 2021, 12:11 PM

ashley claimed this task.

ashley added a commit: rEATCaeabc5388709: Cleanup & rework.