Page MenuHomePhabricator

[wmf.16-regression] Default filters with Excluded namespaces don't preserve exclude status when loaded via 'Restore default filters'
Closed, ResolvedPublic

Description

  1. In testwiki on RC page save a filter with excluded namespace(s) as a default filter.
  2. Load the filter - the filter will display 'not' for excluded namespaces and, accordingly, filter out excluded namespaces from displayed changes.
  3. Click on the trashbin to discard the currently viewed filter (it may be any filter). Click on 'Restore default filters' - the filter will be displayed without 'not' and won't filter excluded namespaces.

Details

Related Gerrit Patches:

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 29 2017, 9:29 PM

Change 374647 had a related patch set uploaded (by Mooeypoo; owner: Mooeypoo):
[mediawiki/core@master] RCFilters: Include invert param when reading default saved query

https://gerrit.wikimedia.org/r/374647

Change 374647 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Include invert param when reading default saved query

https://gerrit.wikimedia.org/r/374647

Etonkovidova updated the task description. (Show Details)Aug 30 2017, 4:49 PM

Checked the fix in betalabs.

Etonkovidova closed this task as Resolved.Aug 30 2017, 10:35 PM
Etonkovidova triaged this task as High priority.