|Open||None||T174562 LoginNotify should inform users of the IP address of successful login attempts to their account|
|Resolved||Huji||T183722 Maintenance script to generate fake login attemps from any IP|
|Resolved||Huji||T187519 loginAttempt.php should use a hook, not a LoginNotify instance|
- Mentioned In
- T249408: Show useragent data and username on new device login emails
T205928: Improve Login alert when user logs in from new machine
T187519: loginAttempt.php should use a hook, not a LoginNotify instance
T174388: LoginNotify should inform users of the IP address of failed login attempts to their account
- Mentioned Here
- T174388: LoginNotify should inform users of the IP address of failed login attempts to their account
I'd personally prefer to combine both requests in one task since it's not very different, technically speaking. The software changes required for both are pretty much the same (i.e the changes will be made in one place and not two).
The reason I separated them out is because it is possible that we may want to do one and not the other, so I think considering them separately helps. If you use the same patch for both, it can be tagged against multiple tasks, so there's no overhead there.
Anyway, I'm not strongly tied to any particular task configuration. It's your project, so if you'd prefer to merge them together, I have no objections. :-)
I started working on it but I found out that the first thing we need is a way to create login records from an arbitrary IP address (because I only have one test VM, and all edits from it will have the same IP i.e. 127.0.0.1
I worked on creating a maintenance script that would create a login attempt from an arbitrary IP, and tried to model after our unit testing code, but did not finish the job. I think it is best if we create a subtask for it, and perhaps someone else can help develop that script. Overall, any help in this area is appreciated, as I have run into a bit of difficulty finding time to work on patches recently.