Quim added me as a publisher (in a single step, I've confirmed with him).
I received two notifications.
Description
Details
Project | Branch | Lines +/- | Subject | |
---|---|---|---|---|
mediawiki/extensions/Newsletter | master | +0 -14 | Remove duplicate newsletter-newpublisher create event |
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Duplicate | Qgil | T125545 Phabricator Q&A session for Community Liaisons | |||
Resolved | Qgil | T116025 Goal: Align Community Liaison and Developer Relations project management practices | |||
Resolved | Qgil | T119387 Community Liaison and Developer Relation quarterly goals for January - March 2016 | |||
Declined | None | T104131 Exporting existing newsletter to the Newsletter extension | |||
Resolved | • Addshore | T110170 Goal: Deploy Newsletter extension in Wikimedia | |||
Resolved | Qgil | T173111 Testing Newsletter extension in test.wikipedia.org | |||
Resolved | • Addshore | T174602 Double notification received for becoming a Newsletter publisher |
Event Timeline
This bug has been confirmed by another user in another test.
@01tonythomas do you have any idea about where this might be coming from? Although technically this bug is not a big deal, it causes a poor first impression to new publishers about the stability and reliability of this new extension.
@Qgil I just tried to reproduce this - but sadly couldnt. I just get one notification. My only assumption was that the form was submitted twice. Can you check this thing now (after our yesterdays patch - which was unrelated though) ?
@01tonythomas I just added you as publisher to https://test.wikipedia.org/wiki/Newsletter:The_Technical_Collaboration_Observer
Did you receive one or two notifications?
I can see it there. Woah. Strange I cannot reproduce (making me think that someone should look at the Echo jobs logs).
I think I have found the problem. There is something fishy triggering notifications when the user who adds a publisher is an administrator:
- When a publisher who is not an administrator adds a publisher, one notification is sent.
- When a publisher who is an administrator adds a publisher, two notifications are sent.
- When an administrator who is not a publisher adds a publisher, two notifications are sent.
I am not sure. I still think there is something with the Echo job queue here. Might not be a newsletter triggered thing as I tried condition (3) mentioned above just now - and only got *one*. Can someone from the echo team take a look, or someone with Echo jobs take a look at what is happening ?
There are 2 EchoEvent::create calls for "EchoEvent::create"
One in NewsletterDataUpdate and one in NewsletterEditPage
Change 375371 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Newsletter@master] Remove duplicate newsletter-newpublisher create event
But is the NewsletterDataUpdate called on normal edits ? I cannot find that happening on my local instance. In fact, after applying the ^^ patch - I do not get a notification at all. Probably if someone is free, we can test this thing out at newsletter-test.wmflabs.org and decide for sure.
Else, there is something very related to my machine install which do not produce double notifications.
I just added @Quiddity as publisher of Newsletter², a newsletter in MediaWiki.org, and he only got one notification. Should we close this task as... Resolved? If someone hits this problem again, we can reopen.
(Since then I have added more publishers to newsletters, and I have heard no further complaints.)
I've tested again by adding Quim to another newsletter, and it does seem to be fixed, somehow (?). I'll resolve this task, and leave a note on Addshore's unmerged patchset.
Change 375371 abandoned by Addshore:
Remove duplicate newsletter-newpublisher create event