Page MenuHomePhabricator
Create Task
Maniphest T174613

Remove use of deprecated EditPage::getCheckboxes() in VE
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Remove use of deprecated EditPage::getCheckboxes() in VE. getCheckboxesDefinition() is in fact much more convenient for us, since we won't have to extract stuff from HTML chunks.

Details

SubjectRepoBranchLines +/-
Stop requiring deprecated EditPage::getCheckboxes()mediawiki/extensions/VisualEditormaster+50 -51
Remove use of deprecated EditPage::getCheckboxes()mediawiki/extensions/VisualEditormaster+0 -4
EditPage: Make getCheckboxesDefinition() publicmediawiki/coremaster+1 -1
Customize query in gerrit

Event Timeline

matmarex created this task.Aug 30 2017, 8:15 PM
Restricted Application added a project: VisualEditor. · View Herald TranscriptAug 30 2017, 8:15 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
matmarex claimed this task.Aug 30 2017, 8:15 PM
gerritbot subscribed.Aug 31 2017, 3:57 PM

Change 375019 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] EditPage: Make getCheckboxesDefinition() public

https://gerrit.wikimedia.org/r/375019

gerritbot added a project: Patch-For-Review.Aug 31 2017, 3:57 PM

Change 375020 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Stop requiring deprecated EditPage::getCheckboxes()

https://gerrit.wikimedia.org/r/375020

gerritbot added a comment.Aug 31 2017, 3:57 PM

Change 375021 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Remove use of deprecated EditPage::getCheckboxes()

https://gerrit.wikimedia.org/r/375021

gerritbot added a comment.Aug 31 2017, 5:37 PM

Change 375019 merged by jenkins-bot:
[mediawiki/core@master] EditPage: Make getCheckboxesDefinition() public

https://gerrit.wikimedia.org/r/375019

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)).Aug 31 2017, 6:00 PM
• Deskana set the point value for this task to 1.Sep 5 2017, 12:33 PM
• Deskana moved this task from To Triage to TR1: Releases on the VisualEditor board.
• Deskana triaged this task as Medium priority.Sep 5 2017, 12:39 PM
gerritbot added a comment.Sep 5 2017, 6:00 PM

Change 375020 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Stop requiring deprecated EditPage::getCheckboxes()

https://gerrit.wikimedia.org/r/375020

gerritbot added a comment.Sep 14 2017, 7:20 PM

Change 375021 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Remove use of deprecated EditPage::getCheckboxes()

https://gerrit.wikimedia.org/r/375021

ReleaseTaggerBot edited projects, added MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)); removed MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)).Sep 14 2017, 8:00 PM
matmarex closed this task as Resolved.Sep 19 2017, 4:33 PM
matmarex removed a project: Patch-For-Review.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptSep 19 2017, 4:33 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL