Page MenuHomePhabricator

Make 'Other review tools' (MediaWiki:Recentchangestext box) span the entire page
Closed, ResolvedPublic

Description

Regression: The "Other review tools" link has moved so that it is no longer aligned vertically to the center of the Saved Filters menu. Please fix.


On some wikis, the layouts volunteers have created inside the "Other review tools" box (MediaWiki:Recentchangestext) don't respond well to the narrower box dimensions that we created when we made this fit on the same line as the Saved Filters menu.

To ease this crunch a bit, we'd like to change the structure of the page so that the collapse/expand box works as illustrated below. Namely:

  • When the box is closed, the "Other review tools" link and the Saved Filters menu are on the same line vertically.
  • When the box is expanded then the Saved Filters menu is is pushed down on its own line, so that Other Review Tools can span the page.
CollapsedExpanded

Event Timeline

Change 374911 had a related patch set uploaded (by Mooeypoo; owner: Mooeypoo):
[mediawiki/core@master] RCFilters: Make top links in RecentChanges expand to full-width

https://gerrit.wikimedia.org/r/374911

Change 374911 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Make top links in RecentChanges expand to full-width

https://gerrit.wikimedia.org/r/374911

Checked in betalabs (also did some additional checking along with other UI browser testing in SauceLabs for IE11/Wind10 and Wind7) combination.

Expanded state

Collapsed state

QA Recommendation: Resolve

jmatazzoni closed this task as Resolved.Sep 1 2017, 10:04 PM
jmatazzoni reopened this task as Open.Nov 21 2017, 6:36 PM

The "Other review tools" link has moved so that it is no longer aligned vertically to the center of the Saved Filters menu. Please fix.

jmatazzoni renamed this task from Make 'Other review tools' (MediaWiki:Recentchangestext box) span the entire page to Regression: Make 'Other review tools' (MediaWiki:Recentchangestext box) span the entire page.Nov 21 2017, 6:38 PM
jmatazzoni updated the task description. (Show Details)
Etonkovidova added a comment.EditedNov 21 2017, 9:11 PM

It'd be better to split the issue described below as a separate regression ticket.

The "Other review tools" link has moved so that it is no longer aligned vertically to the center of the Saved Filters menu. Please fix.

In wmf.7 (enwiki): the screenshot shows a slight misalignment.

Filed as T181096: [wmf.7-regression] minor - mw-rcfilters-ui-savedLinksListWidget misaligned with mw-rcfilters-ui-row element

Etonkovidova renamed this task from Regression: Make 'Other review tools' (MediaWiki:Recentchangestext box) span the entire page to Make 'Other review tools' (MediaWiki:Recentchangestext box) span the entire page.Nov 21 2017, 9:25 PM
Etonkovidova closed this task as Resolved.

@Etonkovidova, I still see the misalignment on beta. What made you close the task? Are you writing a replacement?