Page MenuHomePhabricator

Newsletter extension doesn't notify users when they are removed as publishers
Closed, ResolvedPublic

Description

The Newsletter extension sends a notification to users when they are added as publishers to a newsletter. Good!

However, no notification is sent when they are removed as publishers. They should be aware, especially considering a scenario where another publisher or an admin has removed them without their knowledge and/or against their will.

Event Timeline

QuimGil raised the priority of this task from Medium to High.Sep 10 2017, 9:23 PM

Not a proper notification, but user Qgil-WMF removed user QuimGil as a test, and this is what QuimGil received via email:

Dear QuimGil,

The MediaWiki page User:QuimGil has been changed on 13 September 2017 by
Qgil-WMF, see https://www.mediawiki.org/wiki/User:QuimGil for the
current revision.

Editor's summary: -

In this specific case, in https://www.mediawiki.org/wiki/User:QuimGil there is nothing to see. Literally, is a copy from my user page in Meta. It doesn't have a History or anything to see.

Change 384262 had a related patch set uploaded (by 01tonythomas; owner: 01tonythomas):
[mediawiki/extensions/Newsletter@master] Add notificaiton on removing a publisher

https://gerrit.wikimedia.org/r/384262

How long will there go for another +2 user has checked it? - And how many are there with +2.

The last patch has been waiting for a review 11 days. It's a pity, because a lot of work has been put in that changeset and its iterations. @Addshore could you help reviewing, please?

Change 384262 merged by jenkins-bot:
[mediawiki/extensions/Newsletter@master] Add notification on removing a publisher

https://gerrit.wikimedia.org/r/384262