On the article view, when I force press an image:
- The preview should not show the share and close actions, only the image, caption and licese
- I should be able to access the Share action via the peek actions (currently there are no peek actions)
• JMinor | |
Aug 31 2017, 6:32 PM |
F10020129: IMG_1608.jpg | |
Oct 5 2017, 5:52 PM |
F10020127: IMG_1607.jpg | |
Oct 5 2017, 5:52 PM |
F10004701: T174714 (Swipe the image).PNG | |
Oct 4 2017, 9:53 PM |
F10004700: T174714 (Force Press an Image).PNG | |
Oct 4 2017, 9:53 PM |
F9963696: IMG_A5B928438053-1.jpeg | |
Oct 2 2017, 10:00 PM |
On the article view, when I force press an image:
On the article view, when I long press a link:
What do you mean by "a link" - a link to an image? an image inline in an article? both?
On the gallery view
The preview should not show only the image (currently there is no peek)
I should be able to access the Share action via the peek actions (currently there are no peek actions)
So you want to be able to peek by 3d touching the current visible image in the gallery? Or do you mean the long press menu that currently only shows copy? If you do mean peek by 3d touching, is there precedent for other apps that peek that don't pop? or would pop go to another gallery?
@NHarateh_WMF unfortunately I'm still seeing the close and share buttons on 5.7.0 (1232) and although the peek action is appearing on scroll up, tapping on 'Share' closes the preview without opening the share sheet.
@cmadeo what device and OS?
It looks like 5.7 doesn't have the latest changes, develop does. Will move this to Waiting for Build for now.
@NHarateh_WMF Sorry it's appearing correctly on 5.7.0 (1234) for me on an iPhone 7 running iOS 11.1
Testing on iPhone 6s (iOS 10.3.3) and Wikipedia app 5.7.0 (1235). This is fixed as shown in the first image there is no Share button when peeking, Share only appears after swiping up on the image.
Testing on 5.7.0 (1236)
This is working for the lead image, but the share and close buttons are still present on subsequent images.