Turn off 'classic' ORES highlighting on the Watchlist (with beta)
Closed, ResolvedPublic

Description

When we implement the New Filters beta on Watchlist, we need to turn off the automatic ORES highlighting that existed before, so it doesn't conflict with the new user-defined highlighting on this page. (ORES highlighting will continue to be an option on the non-beta Watchlist and the Contributions page. See T173716 and its sub-tasks for details.)

Change 375417 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/core@master] RCFilters: make is isStructuredFilterUiEnabled public

https://gerrit.wikimedia.org/r/375417

Change 375418 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/ORES@master] RCFilters: hide ores highlight and "r" on watchlist beta

https://gerrit.wikimedia.org/r/375418

Change 375417 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: make isStructuredFilterUiEnabled public

https://gerrit.wikimedia.org/r/375417

Change 375418 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] RCFilters: hide ores highlight and "r" on watchlist beta

https://gerrit.wikimedia.org/r/375418

Etonkovidova added a comment.EditedThu, Sep 7, 11:44 PM

Checked in betalabs - when beta feature is enabled, the settings from Preferences - Watchlist - 'Revision scoring' will be ignored.

@SBisson Two questions:

(1) When beta feature for enabling filters on Watchlist will be in place, the section for 'Revision scoring' on Preferences - Watchlist should be hidden?

(2) The option 'Show only likely problem edits (and hide probably good edits)' does not seem to be working after opting out of beta feature.

The test case:

  • Make an edit as anonymous user (those are usually marked by one of the as 'May be bad' etc) on a watched page.
  • Login as the user on which watched page that problematic edit was made (from the above step). Make sure that the edits gets fetched with 'May have problems' filter.

  • Disable beta feature for filters. Also, go to Preference - Watchlist and enable two options: 'Highlight likely problem edits with colors and an "r" for "needs review"' 'Show only likely problem edits (and hide probably good edits)' Also, enable the option 'May have problems (flags most problems ...' in 'Prediction threshold'
  • the Watchlist page will display the problematic edit with 'r' and ORES highlight and the option 'Hide probably good edits' will checked, but the edits will be displayed regardless of their ORES scores.

  • disable the option 'Hide probably good edits' - the result set on the Watchlist page remains unchanged.

Change 376719 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/core@master] WLFilters: Respect default values

https://gerrit.wikimedia.org/r/376719

Checked in betalabs - when beta feature is enabled, the settings from Preferences - Watchlist - 'Revision scoring' will be ignored.

@SBisson Two questions:

(1) When beta feature for enabling filters on Watchlist will be in place, the section for section 'Revision scoring' on Preferences - Watchlist should be hidden?

The beta feature is already in place. The "New filters for edit review" used to be only for RC but now it's going to be for Watchlist as well. The language will be updated when Watchlist is included.

Disabling classic ORES highlighting is something that came up late last week that we all forgot to include in the initial WL release plan. We did not discuss changing the preferences in any way at this time but it's a valid question for @jmatazzoni.

(2) The option 'Show only likely problem edits (and hide probably good edits)' does not seem to be working after opting out of beta feature.

That's a genuine bug. Fixed in https://gerrit.wikimedia.org/r/376719

Change 376719 merged by jenkins-bot:
[mediawiki/core@master] WLFilters: Respect default values

https://gerrit.wikimedia.org/r/376719

Change 376766 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/core@wmf/1.30.0-wmf.17] WLFilters: Respect default values

https://gerrit.wikimedia.org/r/376766

Change 376793 had a related patch set uploaded (by Mattflaschen; owner: Mattflaschen):
[mediawiki/core@master] RCFilters: Remove getValue and use FormOptions

https://gerrit.wikimedia.org/r/376793

Etonkovidova added a comment.EditedFri, Sep 8, 9:30 PM

Checked the last patch in betalabs - default values (with the disabled beta feature for new filters) work as expected.

QA Recommendation: Resolve

Change 376793 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Remove getValue and use FormOptions

https://gerrit.wikimedia.org/r/376793

Change 376766 merged by jenkins-bot:
[mediawiki/core@wmf/1.30.0-wmf.17] WLFilters: Respect default values

https://gerrit.wikimedia.org/r/376766

Checked the latest fix in betalabs.

Etonkovidova closed this task as Resolved.Mon, Sep 11, 3:22 PM

Mentioned in SAL (#wikimedia-operations) [2017-09-12T13:25:33Z] <hashar@tin> Synchronized php-1.30.0-wmf.17/includes/changes/ChangesListBooleanFilter.php: WLFilters: Respect default values - T174725 (duration: 00m 45s)