Page MenuHomePhabricator

Page Preview preference should be a checkbox
Open, LowPublic

Description

Steps to find out

  1. Open preferences on any wiki
  2. See features like MediaViewer or Revision-Slider have got checkbox switch
  3. Only Page-Previews is different as it has got two enable/disable radio buttons
  4. This is not really unified per my opinion and can be confusing a little bit too

Event Timeline

Dvorapa created this task.Aug 31 2017, 8:51 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 31 2017, 8:51 PM
Dvorapa updated the task description. (Show Details)Aug 31 2017, 8:51 PM
Nirzar added a comment.Sep 5 2017, 6:55 PM

this is about the modal window to disable the page previews.

  • Making it obvious to disable page previews was part of the design criteria
  • We did usertest this part of the feature.. an explicit "disable" is preferred over unchecking a box

Thank you for your suggestion, we would probably need to move over to checkbox later down the line when page previews are more commonplace and people know about it.

To begin with, we would like to retain the disabling model.

Volker_E added a comment.EditedSep 5 2017, 7:03 PM

There has been some work on T117781: Convert Special:Preferences to OOUI.
With that in, the ToggleSwitchWidget would fulfill both needs as most appropriate widget in the long-term and work for the other two features as well, similar to T169807 already raised.

Volker_E triaged this task as Low priority.Sep 5 2017, 7:03 PM
Nirzar changed the task status from Open to Stalled.Sep 6 2017, 10:11 PM

@Volker_E
Yes. but that would be much later down the line.

ovasileva moved this task from Backlog to For Review on the Page-Previews board.Feb 26 2018, 4:03 PM
Restricted Application added a subscriber: Zoranzoki21. · View Herald TranscriptMar 15 2018, 3:51 PM
Nirzar changed the task status from Stalled to Open.Apr 2 2018, 4:52 PM

I'll note that this is trivial technically, since the radio preference already uses the values 1 for enabled and 0 for disabled, which is the same as a checkbox preference would use for the checked/unchecked state. You can just change 'type' => 'radio' to 'type' => 'check' and the preference works correctly (and doesn't lose the existing user prefs). If this was intentional, then I applaud Popups' devs' foresight :)

So I guess someone needs to decide on the timing, remove some other dead code and unused messages, and possibly adjust the wording to look better with the checkbox (see also T203992: Random italicized text under Reading preferences section on Special: Preferences > Appearance tab).

There has been some work on T117781: Convert Special:Preferences to OOUI.
With that in, the ToggleSwitchWidget would fulfill both needs as most appropriate widget in the long-term and work for the other two features as well, similar to T169807 already raised.

Is there a task about moving Special:Preferences to ToggleSwitchWidget on desktop some time in the future?