Page MenuHomePhabricator

failed stubbing in tests.
Closed, ResolvedPublic

Description

Runing quint tests on master currently returns 2 errors (on Firefox):

  • Pressing keyboard shortcut for skipping ahead word and
  • Pressing keyboard shortcut for skipping back word.

Similarly https://gerrit.wikimedia.org/r/#/c/354010 triggers Pressing keyboard shortcut for skipping ahead sentence (but not the above two).

The source for this seems to be that the stubbed functions in testKeyboardShortcut() are not actually the ones called in when the keydown event is triggered.

Event Timeline

Lokal_Profil created this task.
Lokal_Profil moved this task from Backlog to Technical debt on the Wikispeech-WMSE board.

Pressing keyboard shortcut for skipping ahead sentence has been commented out in https://gerrit.wikimedia.org/r/#/c/354010 with a reference to this ticket.

In the future (and maybe for this one too, if it isn't solved soon), use skip(), unless Jenkins has problem with this.

Change 398851 had a related patch set uploaded (by Sebastian Berlin (WMSE); owner: Sebastian Berlin (WMSE)):
[mediawiki/extensions/Wikispeech@master] Refactor Javascript modules

https://gerrit.wikimedia.org/r/398851

Change 398851 merged by jenkins-bot:
[mediawiki/extensions/Wikispeech@master] Refactor Javascript modules

https://gerrit.wikimedia.org/r/398851