[BUG] Fix edit preview article theme
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Mhurd
	Sep 2 2017, 3:48 AM

Description

How many times were you able to reproduce it?

Always.

Steps to reproduce

Load an article
Turn on dark theme
Tap edit pencil
Make a change
Tap "Next"
Scroll down to see the preview of your changes

Expected results

The preview should be using dark theme

Actual results

Preview is un-themed

Screenshots

Screen Shot 2017-09-01 at 8.54.52 PM.png (1×862 px, 159 KB)

Environments observed

App version:
5.6.1

OS versions:
iOS 10.3 and 11

Device model:
iPhone 6 (any)

Device language:
EN

Regression?

Yes

Tag task with Regression

Related Objects

Mentioned In: rAPIOS36250d995d70: Merge pull request #1780 from wikimedia/regression/edit-preview-theme/T174842

Event Timeline

Mhurd created this task.Sep 2 2017, 3:48 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 2 2017, 3:48 AM

Mhurd added a project: iOS-app-v5.6.1-Goat-On-A-Plane.Sep 2 2017, 3:48 AM

Mhurd moved this task from Tasks from Product Backlog to Needs Code Review on the iOS-app-v5.6.1-Goat-On-A-Plane board.

https://github.com/wikimedia/wikipedia-ios/pull/1780

@ABorbaWMF I fixed that issue you gchat'ed me yesterday! :)

@ABorbaWMF good catch!

JoeWalsh mentioned this in rAPIOS36250d995d70: Merge pull request #1780 from wikimedia/regression/edit-preview-theme/T174842.Sep 5 2017, 3:38 PM

I don't think this is in scope for 5.6.1, moving 5.7

• JMinor triaged this task as Low priority.Sep 5 2017, 5:06 PM

@JMinor Just a heads-up that this was working in 5.6.0 and will be a regression in 5.6.1

Mhurd moved this task from Tasks from Product Backlog to Waiting for Build on the iOS-app-v5.7.0-Corgi-On-A-Surfboard board.Sep 7 2017, 9:36 PM

• JMinor moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.Sep 11 2017, 6:22 PM

JoeWalsh moved this task from Waiting for Build to Needs Design Review on the iOS-app-v5.7.0-Corgi-On-A-Surfboard board.Sep 21 2017, 11:14 AM

Looks good, thanks for catching and fixing this @Mhurd!

Tested on iPhone 7+ with iOS 11.0, iPad with iOS 11.0, and iPhone 4 with iOS 9.3.5 on App 5.7.0 (1228)

Looks good now!

• JMinor closed this task as Resolved.Oct 30 2017, 9:32 PM

	F9280955: Screen Shot 2017-09-01 at 8.54.52 PM.png
	Sep 2 2017, 3:55 AM

[BUG] Fix edit preview article themeClosed, ResolvedPublicActions