Page MenuHomePhabricator

tool extreg-wos not updating its table
Closed, InvalidPublic

Description

https://tools.wmflabs.org/extreg-wos/ is seemingly not working. It says that it's updated hourly but it is not updating currently. Take T173058 for example, which was created on August 11; now go to the AdminLinks section and you'll see it red. Can you please restart it and make it update again? Thanks.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 2 2017, 8:39 PM
MarcoAurelio renamed this task from tool extreg-wos not working to tool extreg-wos not updating its table.Sep 2 2017, 8:44 PM
SamanthaNguyen added a subscriber: SamanthaNguyen.EditedSep 2 2017, 9:00 PM

It updates, it's just that this tool is currently hardcoded to detect substrings in Maniphest task titles that match Convert {extension} to use. See this block (also https://github.com/wikimedia/labs-tools-extreg-wos/blob/master/generate.py#L105 ):

generate.py
try:
            ext_name = phid_info['fullName'].split('Convert ', 1)[1].split('to use', 1)[0].strip()
            ext_name = ext_name.split('extension', 1)[0].strip()

Notice that there is no "Extension" prefix. For example, in this instance it's explicitly looking for a substring Convert AdminLinks to use, but that doesn't exist. Instead, the first part of that tile is Convert Extension:AdminLinks to use

Krenair added a subscriber: Krenair.Sep 2 2017, 9:10 PM

A lot of tasks are like that - see the related objects on T98668

Krenair added a comment.EditedSep 2 2017, 9:21 PM

I changed the titles on them. Let's see if it updates now.

T173058
T171819
T174483
T174530
T174529
T174478
T174456
T174663
T174661
T174657
T174483

After an hour, they've been updated (2017-09-02 22:16:00.532121) - now "Patch to review" is shown for these, with the appropriate task linked. Not really sure what else needs to be done here(?) Personally I like that a task naming standard is technically enforced by the tool so they're consistent.

SamanthaNguyen closed this task as Invalid.Sep 2 2017, 10:21 PM

Well, this task was created originally as a misunderstanding of what was going on, so I'm going to close this as invalid. Cheers 👍

Thanks all. Maybe the title standards should be mentioned in some place for future reference, or the tool amended to detect that from subtasks of both bugs? Regards.