Page MenuHomePhabricator

Deletion notice box on history pages shows "protection" at the top, even though the actual log is not
Closed, ResolvedPublic

Description

When viewing the history for a deleted and creation-protected page, such as Saeed Khan Bozdar, the protection log is not shown but "protection" appears at the top of the box. This is caused by T171338, which does not account for history pages.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 3 2017, 3:21 PM

Change 372775 had a related patch set uploaded (by GeoffreyT2000; owner: GeoffreyT2000):
[mediawiki/core@master] Use original message on history pages

https://gerrit.wikimedia.org/r/372775

Change 375618 had a related patch set uploaded (by Ebe123; owner: Ebe123):
[mediawiki/core@master] Show protection log on every use of moveddeleted-notice

https://gerrit.wikimedia.org/r/375618

Ebe123 added a subscriber: Ebe123.Sep 3 2017, 5:10 PM

Didn't notice the other places where the message is used. However, having the protection log can still be useful on history pages (and image pages, which I also forgot), as evidenced on T171338. I have submitted another patch to add the protection log. Duplicating (or near) a message causes more trouble and the result is less useful than what I'm proposing.

Change 372775 abandoned by GeoffreyT2000:
Use original message on history pages

Reason:
See Ib9f22d6e06c372c4a32e77a08c846d768853bc21, which includes image pages as well and does not add a new i18n message.

https://gerrit.wikimedia.org/r/372775

GeoffreyT2000 renamed this task from Deletion notice box on history pages shows "protection" at the top to Deletion notice box on history pages shows "protection" at the top, even though the actual log is not.Sep 3 2017, 11:54 PM

Change 375618 merged by jenkins-bot:
[mediawiki/core@master] Show protection log on every use of moveddeleted-notice

https://gerrit.wikimedia.org/r/375618