Page MenuHomePhabricator

Don't float betafeatures-auto-enroll checkbox
Closed, ResolvedPublic1 Estimate Story Points

Description

Currently, all .mw-ui-feature-checkbox divs are being floated left because when it's used in feature fields it has 'Information' and 'Discussion' to its right. However, there is one usage of the checkbox that doesn't have anything next to it: the betafeatures-auto-enroll one. This does not need to float left because there's nothing to its right.

This doesn't normally matter, because it's in a table cell and doesn't break anything, but if it's used instead in a form with the 'div' display format then things can get a bit wonky.

(This is with regard to making it work with global preferences.)

Details

Related Gerrit Patches:
mediawiki/extensions/BetaFeatures : masterDon't float betafeatures-auto-enroll checkbox

Event Timeline

Samwilson created this task.Sep 4 2017, 5:50 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 4 2017, 5:50 AM

Change 375724 had a related patch set uploaded (by Samwilson; owner: Samwilson):
[mediawiki/extensions/BetaFeatures@master] Don't float betafeatures-auto-enroll checkbox

https://gerrit.wikimedia.org/r/375724

Change 375724 merged by jenkins-bot:
[mediawiki/extensions/BetaFeatures@master] Don't float betafeatures-auto-enroll checkbox

https://gerrit.wikimedia.org/r/375724

Samwilson closed this task as Resolved.Sep 5 2017, 10:43 PM
Samwilson claimed this task.
Samwilson triaged this task as Medium priority.
Samwilson set the point value for this task to 1.
Samwilson moved this task from Ready to Q1 2018-19 on the Community-Tech-Sprint board.