Page MenuHomePhabricator
Create Task
Maniphest T174945

Spacing in expanded templates
Closed, ResolvedPublic
Actions

Description

Example @ line 408:

https://en.wikipedia.org/w/index.php?title=Adrian_Lamo&type=revision&diff=798906470&oldid=798761681

IABot adds spacing to the |interviewer argument .. however this causes the template in the wikitext to look messed up. The original authors had the "=" lined up so it is easy to read and looks nice. The number of spaces between the end of the argument name and the "=" sign are variable. But the total number of characters (include spaces) from the start of the argument name to the "=" would be the same for all arguments.

I ran into this wiki Medic and came up with some functions to determine spacing and have the "=" signs lined up (assuming that was the original intent).

Event Timeline

Green_Cardamom created this task.Sep 4 2017, 2:24 PM
Restricted Application assigned this task to Cyberpower678. · View Herald TranscriptSep 4 2017, 2:24 PM
Restricted Application added a subscriber: Cyberpower678. · View Herald Transcript
Cyberpower678 added a comment.Sep 4 2017, 7:52 PM

IABot attempts to read the formatting. But it's not able to recognize lined up arguments. It tries to read the spacing of the arguments, and uses the one most common in the template, and follows through with it. Something to consider as an update.

Cyberpower678 triaged this task as Medium priority.Sep 4 2017, 7:54 PM
Cyberpower678 moved this task from Inbox to v1.5 on the InternetArchiveBot board.
Cyberpower678 edited projects, added InternetArchiveBot (v1.5); removed InternetArchiveBot.
Cyberpower678 moved this task from Unsorted to Bugs on the InternetArchiveBot (v1.5) board.
Cyberpower678 closed this task as Resolved.Sep 5 2017, 3:37 PM

Implemented in v1.5.1

Green_Cardamom added a comment.Sep 5 2017, 4:02 PM

Great! Hope it wasn't too difficult. Occurred to me the easiest method would be 1) determine if there is padded spacing involved and if so 2) change all to the length of the longest argument + 1 space.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL