Page MenuHomePhabricator
Create Task
Maniphest T174948

Deploy 'hack' patch & logging for tracking user registrations and guided tour
Closed, ResolvedPublic
Actions

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/WikimediaEventsmaster+2 -2onBeforeInitializeWMDECampaign, fix early bail condition
mediawiki/extensions/WikimediaEventswmf/1.30.0-wmf.19+2 -2onBeforeInitializeWMDECampaign, fix early bail condition
mediawiki/extensions/WikimediaEventsmaster+1 -1Fix second campaign param check in onBeforeInitializeWMDECampaign
mediawiki/extensions/WikimediaEventsmaster+109 -0Setup WMDE editor campaign tracking
operations/mediawiki-configmaster+1 -0Add WMDE log channel
Customize query in gerrit

Related Objects

Event Timeline

Verena created this task.Sep 4 2017, 2:41 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 4 2017, 2:41 PM
Verena added a comment.Sep 4 2017, 2:42 PM

This includes setting up the logging in production for the change

Verena added a subscriber: • Stefan_Schneider_WMDE.Sep 4 2017, 2:42 PM
Addshore added a project: User-Addshore.Sep 5 2017, 3:17 PM
Tobi_WMDE_SW added a project: WMDE-QWERTY-Sprint-2017-09-05.Sep 5 2017, 3:25 PM
Addshore renamed this task from Deploy patch&logging for tracking user registrations and guided tour to Deploy 'hack' patch & logging for tracking user registrations and guided tour.Sep 6 2017, 8:30 AM
Addshore moved this task from Unsorted 💣 to Back Burner 🏛️ on the User-Addshore board.
Addshore moved this task from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2017-09-05 board.
gerritbot added a subscriber: gerritbot.Sep 6 2017, 8:33 AM

Change 376191 had a related patch set uploaded (by Addshore; owner: Addshore):
[operations/mediawiki-config@master] Add WMDE log channel

https://gerrit.wikimedia.org/r/376191

gerritbot added a project: Patch-For-Review.Sep 6 2017, 8:33 AM
Addshore claimed this task.Sep 6 2017, 8:34 AM
gerritbot added a comment.Sep 6 2017, 8:48 AM

Change 376191 merged by jenkins-bot:
[operations/mediawiki-config@master] Add WMDE log channel

https://gerrit.wikimedia.org/r/376191

Stashbot added a subscriber: Stashbot.Sep 6 2017, 8:49 AM

Mentioned in SAL (#wikimedia-operations) [2017-09-06T08:49:53Z] <addshore@tin> Synchronized wmf-config/InitialiseSettings.php: T174948 [[gerrit:376191|Add WMDE log channel]] (duration: 00m 49s)

Addshore added a comment.Sep 11 2017, 10:01 AM

The campaign names can be found in T174952#3595367

(1) ?campaign=wmde_abc2017_bt1 - banner for Specific Task 1;
(2) ?campaign=wmde_abc2017_bt2 - banner for Specific Task 2;
(3) ?campaign=wmde_abc2017_bt3 - banner for Specific Task 3;
(4) ?campaign=wmde_abc2017_gib_lp - banner for the General Invitation which leads to the Landing Page upon click;
(5) ?campaign=wmde_abc2017_gib_rg - banner for the General Invitation which leads directly to Registration upon click.

Addshore mentioned this in T174952: Preparation for daily reports.Sep 11 2017, 10:01 AM
gerritbot added a comment.Sep 11 2017, 10:43 AM

Change 377229 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/WikimediaEvents@master] Setup WMDE editor campaign tracking

https://gerrit.wikimedia.org/r/377229

Addshore moved this task from Doing to Review on the WMDE-QWERTY-Sprint-2017-09-05 board.Sep 11 2017, 10:43 AM

This ticket refers to "deploying" the patch.
This will not be needed if it is reviewed in good time as it will go out with the train.

Addshore moved this task from Back Burner 🏛️ to Active 🚁 on the User-Addshore board.Sep 11 2017, 10:44 AM
Addshore triaged this task as Medium priority.Sep 13 2017, 11:29 AM
gerritbot added a comment.Sep 14 2017, 3:18 PM

Change 377229 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEvents@master] Setup WMDE editor campaign tracking

https://gerrit.wikimedia.org/r/377229

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)).Sep 14 2017, 4:00 PM
gerritbot added a comment.Sep 15 2017, 11:17 AM

Change 378232 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/WikimediaEvents@master] Fix second campaign param check in onBeforeInitializeWMDECampaign

https://gerrit.wikimedia.org/r/378232

gerritbot added a comment.Sep 15 2017, 11:21 AM

Change 378232 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEvents@master] Fix second campaign param check in onBeforeInitializeWMDECampaign

https://gerrit.wikimedia.org/r/378232

Addshore added a comment.Sep 15 2017, 11:34 AM

The code will be dewiki in production next Thursday!

• Stefan_Schneider_WMDE added a comment.Sep 15 2017, 11:35 AM

Thank You, Adam!

Addshore moved this task from Review to Done on the WMDE-QWERTY-Sprint-2017-09-05 board.Sep 18 2017, 5:11 PM
gerritbot added a comment.Sep 22 2017, 1:10 PM

Change 379748 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/WikimediaEvents@master] onBeforeInitializeWMDECampaign, fix early bail condition

https://gerrit.wikimedia.org/r/379748

gerritbot added a comment.Sep 22 2017, 1:10 PM

Change 379749 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/WikimediaEvents@wmf/1.30.0-wmf.19] onBeforeInitializeWMDECampaign, fix early bail condition

https://gerrit.wikimedia.org/r/379749

Addshore mentioned this in T175912: create test banner on real wiki.Sep 22 2017, 1:13 PM
Addshore added a project: WMDE-QWERTY-Sprint-2017-09-19.
Addshore moved this task from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2017-09-19 board.

I can deploy this fix on Monday.

• Stefan_Schneider_WMDE added a comment.Sep 22 2017, 1:15 PM

Great - then let's test it again on Monday.
Thanks!

gerritbot added a comment.Sep 25 2017, 1:21 PM

Change 379749 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEvents@wmf/1.30.0-wmf.19] onBeforeInitializeWMDECampaign, fix early bail condition

https://gerrit.wikimedia.org/r/379749

Stashbot added a comment.Sep 25 2017, 1:30 PM

Mentioned in SAL (#wikimedia-operations) [2017-09-25T13:30:49Z] <addshore@tin> Synchronized php-1.30.0-wmf.19/extensions/WikimediaEvents/WikimediaEventsHooks.php: SWAT: [[gerrit:379749]] onBeforeInitializeWMDECampaign, fix early bail condition T174948 (duration: 00m 46s)

gerritbot added a comment.Sep 25 2017, 1:32 PM

Change 379748 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEvents@master] onBeforeInitializeWMDECampaign, fix early bail condition

https://gerrit.wikimedia.org/r/379748

Addshore closed this task as Resolved.Sep 25 2017, 1:32 PM
Addshore moved this task from Review to Done on the WMDE-QWERTY-Sprint-2017-09-19 board.
Addshore moved this task from Active 🚁 to Closing ✔️ on the User-Addshore board.
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)).Sep 25 2017, 2:00 PM
Tobi_WMDE_SW moved this task from Campaign Setup to Done on the WMDE-New-Editors-Banner-Campaigns (Banner-Campaign-Autumn) board.Oct 6 2017, 7:00 AM
Tobi_WMDE_SW added a project: WMDE-TechWish.Oct 17 2017, 1:08 PM
Tobi_WMDE_SW moved this task from Proposed to Done on the WMDE-TechWish board.Oct 17 2017, 1:09 PM
Tobi_WMDE_SW moved this task from Done to Demoed on the WMDE-TechWish board.Nov 14 2017, 1:35 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL