Related Objects
Event Timeline
Reuse the patch from the last campaign and adjust it to use the new campaign parameters and guided tour name.
data will be provided here
Guided Tour name: "einfuhrung" Campaign #1 name and link: "tba" Campaign #2 name and link: "tba"
Campaign #3 name and link: "tba"
Campaign #4 name and link: "tba"
Campaign #5 name and link: "tba"
The sample code from last time can be seen @ https://gerrit.wikimedia.org/r/#/c/347831/
check, if a fix needs to be put in place to ensure that registered users can not be logged out, see the banner, click the banner, then log in (NOT REGISTER) and then have a chance of seeing the guided tour.
+1
@GoranSMilovanovic do you remember which ticket it was that detailed what setting it is / what has to be done?
@Addshore Here we go:
- the code that you want to take a look at is https://github.com/wikimedia/mediawiki-extensions-GuidedTour/blob/master/modules/tours/firstedit.js#L23
- the Phab ticket where we've discovered this is https://phabricator.wikimedia.org/T171049
- I've learned about this setting in a discussion with @Mattflaschen-WMF on his Talk Page on MediaWiki.
I've put all these detailed information for us to make sure that we never forget about it :)
So, for guided tours we actually need an edit to https://de.wikipedia.org/wiki/MediaWiki:Guidedtour-tour-einfuhrung.js adding shouldLog: true as in https://github.com/wikimedia/mediawiki-extensions-GuidedTour/blob/master/modules/tours/firstedit.js#L23
@DerHexer would you be able to do this?
Before you do any changes to the https://de.wikipedia.org/wiki/MediaWiki:Guidedtour-tour-einfuhrung.js please ping me. We think about some slight changes to the tour and it would be best to have to touch it only once.
I will take care of it and ping back as soon the changes has been made. (Martin and Verena are not available at the moment).
I just copied the Banner names and links to this task to make shure all information is in place. Also you can find specifications on which banner will be shown in which tag (Banner 1 is about pictures etc.).
(1)
Name: bt1 (picture)
Link: ?campaign=wmde_abc2017_bt1 - banner for Specific Task 1;
(2)
Name: bt2 (article)
Link: ?campaign=wmde_abc2017_bt2 - banner for Specific Task 2;
(3)
Name: bt3 (source)
Link: ?campaign=wmde_abc2017_bt3 - banner for Specific Task 3;
(4)
Name: gib_lp (Landingpage)
Link: ?campaign=wmde_abc2017_gib_lp - banner for the General Invitation which leads to the Landing Page upon click;
(5)
Name: gib_rg (Registration)
?campaign=wmde_abc2017_gib_rg - banner for the General Invitation which leads directly to Registration upon click.
I integrated the tracking flag into the code and asked Raymond to replace the code. The task is done. You can double-check here: https://de.wikipedia.org/wiki/MediaWiki:Guidedtour-tour-einfuhrung.js