Page MenuHomePhabricator
Create Task
Maniphest T175064

RelatedArticles not displaying on desktop wikivoyage: Cannot read property 'getBucket' of undefined console error
Closed, ResolvedPublic0.5 Estimated Story Points
Actions

Description

Visit https://en.wikivoyage.org/wiki/Fukushima

Exception in module-execute in module ext.relatedArticles.readMore.eventLogging:
load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:177 TypeError: Cannot read property 'getBucket' of undefined TypeError: Cannot read property 'getBucket' of undefined
    at isEnabledForCurrentUser (eval at <anonymous> (load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:4), <anonymous>:237:548)
    at eval (eval at <anonymous> (load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:4), <anonymous>:237:691)
    at eval (eval at <anonymous> (load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:4), <anonymous>:238:497)
    at Object.<anonymous> (load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:162)
    at fire (load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:45)
    at Object.add [as done] (load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:45)
    at Object.always (load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:46)
    at runScript (load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:162)
    at checkCssHandles (load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:162)
    at execute (load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:163)

To verify fix

Please visit https://en.wikivoyage.org/wiki/Fukushima and open up the console and verify you see an error now.
There should be no JavaScript errors after the deploy on Thursday morning.

Details

SubjectRepoBranchLines +/-
mediawiki.experiments is a dependency of RelatedArticlesmediawiki/extensions/RelatedArticlesmaster+1 -0
Customize query in gerrit

Event Timeline

Jdlrobson created this task.Sep 5 2017, 7:34 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 5 2017, 7:34 PM
Jdlrobson renamed this task from Cannot read property 'getBucket' of undefined console error to RelatedArticles not displaying on desktop wikivoyage: Cannot read property 'getBucket' of undefined console error.Sep 5 2017, 7:36 PM
Jdlrobson added a project: Web-Team-Backlog.
Jdlrobson moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.Sep 5 2017, 7:44 PM
gerritbot subscribed.Sep 5 2017, 7:55 PM

Change 376083 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/RelatedArticles@master] mediawiki.experiments is a dependency of RelatedArticles

https://gerrit.wikimedia.org/r/376083

gerritbot added a project: Patch-For-Review.Sep 5 2017, 7:55 PM
Jdlrobson added projects: Readers-Web-Kanbanana-Board-Old, Unplanned-Sprint-Work.Sep 5 2017, 8:39 PM
Jdlrobson moved this task from To Do to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.
Jdlrobson moved this task from Needs Prioritization to 2017-18 Q1 on the Web-Team-Backlog board.
gerritbot added a comment.Sep 6 2017, 9:37 AM

Change 376083 merged by jenkins-bot:
[mediawiki/extensions/RelatedArticles@master] mediawiki.experiments is a dependency of RelatedArticles

https://gerrit.wikimedia.org/r/376083

Jdlrobson moved this task from Needs Code Review to Ready for Signoff on the Readers-Web-Kanbanana-Board-Old board.Sep 6 2017, 1:52 PM

This cannot easily be QAed or signed off as there is a race condition on wikivoyage.
We can verify it in production next Wednesday if necessary, otherwise we should attempt to verify it locally by loading ext.relatedArticles.readMore.bootstrap in the absence of anything loading mediawiki.experiments.

ovasileva triaged this task as Medium priority.Sep 6 2017, 5:08 PM
ovasileva set the point value for this task to 0.5.
Jdlrobson added a comment.Sep 6 2017, 5:13 PM

There was talk in kick off about whether we want to SWAT this. Although we are only seeing this issue on Wikivoyage desktop, it theoretically could show up elsewhere.

• Jhernandez subscribed.Sep 6 2017, 6:57 PM
In T175064#3585216, @Jdlrobson wrote:

...it theoretically could show up elsewhere.

And we wouldn't notice!

Jdlrobson removed a project: Patch-For-Review.Sep 7 2017, 2:39 PM
Jdlrobson assigned this task to • Niedzielski.Sep 7 2017, 5:54 PM
Jdlrobson updated the task description. (Show Details)

Stephen would you mind signing this off since I'll be away on vacation (note the "verify fix" steps for now and later in the description)?

• Niedzielski added a comment.Sep 7 2017, 6:07 PM

@Jdlrobson, .

I see an error now reproduced here for my own sanity later (note to self: tested in incognito; only took a couple tries; unable to repro when using debug=true):

13:03:45.354 load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:177 TypeError: Cannot read property 'getBucket' of undefined TypeError: Cannot read property 'getBucket' of undefined
    at isEnabledForCurrentUser (eval at <anonymous> (load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:4), <anonymous>:390:548)
    at eval (eval at <anonymous> (load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:4), <anonymous>:390:691)
    at eval (eval at <anonymous> (load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:4), <anonymous>:391:497)
    at Object.<anonymous> (load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:162)
    at fire (load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:45)
    at Object.add [as done] (load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:45)
    at Object.always (load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:46)
    at runScript (load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:162)
    at checkCssHandles (load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:162)
    at execute (load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:163)
logError @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:177
handler @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:155
fire @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:45
fireWith @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:46
fire @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:46
track @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:155
(anonymous) @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:162
fire @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:45
add @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:45
always @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:46
runScript @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:162
checkCssHandles @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:162
execute @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:163
implement @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:169
(anonymous) @ VM82:390
(anonymous) @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:4
globalEval @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:4
(anonymous) @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:167
requestIdleCallback (async)
asyncEval @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:166
work @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:167
enqueue @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:164
load @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:171
(anonymous) @ Fukushima:10
startUp @ load.php?debug=false&lang=en&modules=startup&only=scripts&skin=vector:66
script.onload.script.onreadystatechange @ load.php?debug=false&lang=en&modules=startup&only=scripts&skin=vector:66
13:03:45.402 VM82:120 This page is using the deprecated ResourceLoader module "jquery.ui.core".
Please use "mediawiki.ui.button" or "oojs-ui" instead.
mw.loader.implement.css @ VM82:120
(anonymous) @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:162
fire @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:45
add @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:45
always @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:46
runScript @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:162
checkCssHandles @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:162
(anonymous) @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:163
fire @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:45
fireWith @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:46
fire @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:46
fireCallbacks @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:157
addEmbeddedCSS @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:157
(anonymous) @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:157
requestAnimationFrame (async)
addEmbeddedCSS @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:157
execute @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:163
handlePending @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:159
markModuleReady @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:161
(anonymous) @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:162
fire @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:45
add @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:45
always @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:46
runScript @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:162
checkCssHandles @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:162
(anonymous) @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:163
fire @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:45
fireWith @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:46
fire @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:46
fireCallbacks @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:157
addEmbeddedCSS @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:157
(anonymous) @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:157
requestAnimationFrame (async)
addEmbeddedCSS @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:157
execute @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:163
implement @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:169
(anonymous) @ VM82:62
(anonymous) @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:4
globalEval @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:4
(anonymous) @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:167
requestIdleCallback (async)
asyncEval @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:166
work @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:167
enqueue @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:164
load @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=0ynbgde:171
(anonymous) @ Fukushima:10
startUp @ load.php?debug=false&lang=en&modules=startup&only=scripts&skin=vector:66
script.onload.script.onreadystatechange @ load.php?debug=false&lang=en&modules=startup&only=scripts&skin=vector:66
• Niedzielski added a comment.Sep 7 2017, 9:46 PM

Just to make certain I haven't missed something crucial and time sensitive, I think Jon means for me to check this a week from today as:

  • According to the deployments page, v1.30.0-wmf.17 was deployed and the patch wasn't tagged (but the parent commit is).
  • Jon isn't on holiday until next week.

I've added a note on my calendar to check again next week.

Jdlrobson added a comment.Sep 7 2017, 9:58 PM

Change should roll out in 1.30.0-wmf.18 which I think will be live on 13th.

My last day before vacation is tomorrow

• Niedzielski added a comment.Sep 7 2017, 10:02 PM

Cool. I'll check Wednesday the 13th. (Have a great and restful vacation!)

• Niedzielski added a comment.Sep 13 2017, 5:58 PM

The patch has been tagged v1.30.0-wmf.18 but
group 1 (Wikivoyage) is scheduled for tomorrow. I'll check then.

• Niedzielski closed this task as Resolved.Sep 14 2017, 7:53 PM

This appears to be working properly now so I'm resolving this task.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL