Page MenuHomePhabricator

Run Scribunto test suite on luasandbox patches
Open, LowPublic

Description

For patches submitted to mediawiki/php/luasandbox, we should take the newly built extension and run the Scribunto test suite against it.

This would have caught T175065: Scribunto getfenv/setfenv tests failing.

Event Timeline

Once we've compiled LuaSandbox, you can get PHP to load the local module by using php -dextension=./modules/luasandbox.so ...

The main thing I'm not sure about is whether we should use quibble to run the tests (I would think so), and then how to go about that.