Page MenuHomePhabricator

Linter UI: Provide option to filter linter errors by second column (ex: obsolete tag, missing end tag, stripped tag, etc)
Closed, ResolvedPublic

Description

There have been a couple of different requests to filter the list of linter errors by type of obsolete tag or type of missing end tag, etc. This speaks to the request for a general filtering feature by the content of the second column of special pages like https://en.wikipedia.org/wiki/Special:LintErrors/obsolete-tag


Due to the nature of this code change having a database field addition with an index, it needs to be deployed in a number of phases,

Moving cleanup tasks to a new ticket.

Details

Event Timeline

Change 698266 had a related patch set uploaded (by Sbailey; author: Sbailey):

[mediawiki/extensions/Linter@master] WIP Adding With Template search criteria in Linter Special Page

https://gerrit.wikimedia.org/r/698266

Change 702239 had a related patch set uploaded (by Sbailey; author: Sbailey):

[mediawiki/extensions/Linter@master] WIP Adding linter tag name search criteria in Linter Special Pages

https://gerrit.wikimedia.org/r/702239

Change 712824 had a related patch set uploaded (by Sbailey; author: Sbailey):

[mediawiki/extensions/Linter@master] WIP Adding migrateTemplateAndTagInfo to database code

https://gerrit.wikimedia.org/r/712824

Change 720128 had a related patch set uploaded (by Sbailey; author: Sbailey):

[mediawiki/extensions/Linter@master] WIP First phase of T175177 database alter table adds to fields

https://gerrit.wikimedia.org/r/720128

Change 720130 had a related patch set uploaded (by Sbailey; author: Sbailey):

[mediawiki/extensions/Linter@master] WIP Second phase of T175177 adds RecordLintJob and migrate code

https://gerrit.wikimedia.org/r/720130

Change 720405 had a related patch set uploaded (by Sbailey; author: Sbailey):

[mediawiki/extensions/Linter@master] WIP Third phase of T175177 adds new UI elements and report filtering

https://gerrit.wikimedia.org/r/720405

Change 720128 merged by jenkins-bot:

[mediawiki/extensions/Linter@master] First phase of T175177 database alter table adds two fields

https://gerrit.wikimedia.org/r/720128

See https://integration.wikimedia.org/ci/job/beta-update-databases-eqiad/56488/console

20:30:02 Adding linter_template field to table linter ...RuntimeException from line 5395 of /srv/mediawiki-staging/php-master/includes/libs/rdbms/database/Database.php: Could not open "/srv/mediawiki-staging/php-master/extensions/Linter/sql/patch-linter-template_tag-fields.sql"
20:30:02 #0 /srv/mediawiki-staging/php-master/includes/libs/rdbms/database/DBConnRef.php(69): Wikimedia\Rdbms\Database->sourceFile('/srv/mediawiki-...')
20:30:02 #1 /srv/mediawiki-staging/php-master/includes/libs/rdbms/database/MaintainableDBConnRef.php(35): Wikimedia\Rdbms\DBConnRef->__call('sourceFile', Array)
20:30:02 #2 /srv/mediawiki-staging/php-master/includes/installer/DatabaseUpdater.php(704): Wikimedia\Rdbms\MaintainableDBConnRef->sourceFile('/srv/mediawiki-...')
20:30:02 #3 /srv/mediawiki-staging/php-master/includes/installer/DatabaseUpdater.php(777): DatabaseUpdater->applyPatch('/srv/mediawiki-...', true, 'Adding linter_t...')
20:30:02 #4 /srv/mediawiki-staging/php-master/includes/installer/DatabaseUpdater.php(533): DatabaseUpdater->addField('linter', 'linter_template', '/srv/mediawiki-...', true)
20:30:02 #5 /srv/mediawiki-staging/php-master/includes/installer/DatabaseUpdater.php(501): DatabaseUpdater->runUpdates(Array, true)
20:30:02 #6 /srv/mediawiki-staging/php-master/maintenance/update.php(193): DatabaseUpdater->doUpdates(Array)
20:30:02 #7 /srv/mediawiki-staging/php-master/maintenance/doMaintenance.php(114): UpdateMediaWiki->execute()
20:30:02 #8 /srv/mediawiki-staging/php-master/maintenance/update.php(264): require_once('/srv/mediawiki-...')
20:30:02 #9 /srv/mediawiki-staging/multiversion/MWScript.php(116): require_once('/srv/mediawiki-...')
20:30:02 #10 {main}

Change 760656 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/Linter@master] Fix typo in patch file

https://gerrit.wikimedia.org/r/760656

Change 760656 merged by jenkins-bot:

[mediawiki/extensions/Linter@master] Fix typo in patch file

https://gerrit.wikimedia.org/r/760656

Arlolra updated the task description. (Show Details)

Change 820209 had a related patch set uploaded (by Arlolra; author: Sbailey):

[mediawiki/extensions/Linter@master] Phase 3 of T175177: Migrate code

https://gerrit.wikimedia.org/r/820209

Change 824773 had a related patch set uploaded (by Sbailey; author: Sbailey):

[mediawiki/extensions/Linter@master] Phase 3 of T175177: Migrate code

https://gerrit.wikimedia.org/r/824773

Change 825382 had a related patch set uploaded (by Sbailey; author: Sbailey):

[mediawiki/extensions/Linter@master] Tag and template migrate code phase 3

https://gerrit.wikimedia.org/r/825382

Change 820209 abandoned by Arlolra:

[mediawiki/extensions/Linter@master] Phase 3 of T175177: Migrate code

Reason:

https://gerrit.wikimedia.org/r/820209

Change 825411 had a related patch set uploaded (by Sbailey; author: Sbailey):

[mediawiki/extensions/Linter@master] Phase 3 of T175177: Migrate code

https://gerrit.wikimedia.org/r/825411

Change 825382 abandoned by Sbailey:

[mediawiki/extensions/Linter@master] Tag and template migrate code phase 3

Reason:

Replaced with correctly chained gerrit 825411

https://gerrit.wikimedia.org/r/825382

Change 824773 abandoned by Sbailey:

[mediawiki/extensions/Linter@master] Phase 3 of T175177: Migrate code

Reason:

Replaced with correctly chained gerrit 825411

https://gerrit.wikimedia.org/r/824773

Change 720130 merged by jenkins-bot:

[mediawiki/extensions/Linter@master] Second phase of T175177: Adds template and tag to RecordLintJob

https://gerrit.wikimedia.org/r/720130

Change 826652 had a related patch set uploaded (by Sbailey; author: Sbailey):

[mediawiki/extensions/Linter@master] WIP Phase 4 of Tag and Template search feature, UI and report code

https://gerrit.wikimedia.org/r/826652

Change 833454 had a related patch set uploaded (by Sbailey; author: Sbailey):

[operations/mediawiki-config@master] Enable Linter write of namespace tag and template fields on test2wiki

https://gerrit.wikimedia.org/r/833454

Change 833454 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable Linter write of namespace tag and template fields on beta

https://gerrit.wikimedia.org/r/833454

Change 862373 had a related patch set uploaded (by Sbailey; author: Sbailey):

[mediawiki/extensions/Linter@master] maintenance script for linter extension tag and template migration

https://gerrit.wikimedia.org/r/862373

Change 825411 merged by jenkins-bot:

[mediawiki/extensions/Linter@master] Phase 3 of T175177: Migrate linter_params into new fields

https://gerrit.wikimedia.org/r/825411

Change 862373 merged by jenkins-bot:

[mediawiki/extensions/Linter@master] maintenance script for linter extension tag and template migration

https://gerrit.wikimedia.org/r/862373

Change 868719 had a related patch set uploaded (by Sbailey; author: Sbailey):

[operations/mediawiki-config@master] enable Linter extension maintTagTemplate.php in Beta

https://gerrit.wikimedia.org/r/868719

Change 868719 merged by jenkins-bot:

[operations/mediawiki-config@master] enable Linter extension maintTagTemplate.php in Beta

https://gerrit.wikimedia.org/r/868719

Change 712824 abandoned by Sbailey:

[mediawiki/extensions/Linter@master] WIP Adding migrateTemplateAndTagInfo to database code

Reason:

Replaced with updated patch set

https://gerrit.wikimedia.org/r/712824

Change 826652 had a related patch set uploaded (by Sbailey; author: Sbailey):

[mediawiki/extensions/Linter@master] WIP Tag and Template search feature, UI and report code

https://gerrit.wikimedia.org/r/826652

Change 826652 merged by jenkins-bot:

[mediawiki/extensions/Linter@master] Linter Tag and Template search feature, UI and report code

https://gerrit.wikimedia.org/r/826652

Change 892543 had a related patch set uploaded (by Sbailey; author: Sbailey):

[operations/mediawiki-config@master] enable Linter use namespace field and tag and template UI in Beta

https://gerrit.wikimedia.org/r/892543

Change 698266 abandoned by Sbailey:

[mediawiki/extensions/Linter@master] WIP Adding With Template search criteria in Linter Special Page

Reason:

Code migrated to newer patch chain and now fully merged and in production

https://gerrit.wikimedia.org/r/698266

Change 702239 abandoned by Sbailey:

[mediawiki/extensions/Linter@master] WIP Adding linter tag name search criteria in Linter Special Pages

Reason:

Code migrated to newer patch chains, all now merged and in production

https://gerrit.wikimedia.org/r/702239

Change 892543 merged by jenkins-bot:

[operations/mediawiki-config@master] enable Linter use namespace field and tag and template UI in Beta

https://gerrit.wikimedia.org/r/892543

Sbailey updated the task description. (Show Details)