Page MenuHomePhabricator

Chose how to deal with "Infinity" value for Banners
Closed, ResolvedPublic1 Estimated Story Points

Description

We have seen examples of sample rate being Infinity in banners parameters:

country=IT&anonymous=true&project=wikipedia&db=itwiki&uselang=it&device=android&debug=false&randomcampaign=0.6175000912044197&randombanner=0.5628529652021825&recordImpressionSampleRate=Infinity&status=banner_shown&statusCode=6&campaign=wlm+2017&campaignCategory=wlm2017&campaignCategoryUsesLegacy=false&bucket=1&banner=wlm_2017&bannerCategory=wlm2017&result=show

country=IT&anonymous=true&project=wikipedia&db=itwiki&uselang=it&device=android&debug=false&randomcampaign=0.07829245226457715&randombanner=0.6677659631241113&recordImpressionSampleRate=Infinity&status=banner_shown&statusCode=6&campaign=wlm+2017&campaignCategory=wlm2017&campaignCategoryUsesLegacy=false&bucket=1&banner=wlm_2017&bannerCategory=wlm2017&result=show

Those values make our indexation jobs fail.

How do you want us to deal with ? Remove the rows ? Put 0.0 ? Put 1.0 ?

Event Timeline

Change 382764 had a related patch set uploaded (by Joal; owner: Joal):
[analytics/refinery@master] Filter banners sample_rate = Infinity from Druid

https://gerrit.wikimedia.org/r/382764

Change 382764 merged by Milimetric:
[analytics/refinery@master] Filter banners sample_rate = Infinity from Druid

https://gerrit.wikimedia.org/r/382764

Nuria set the point value for this task to 1.