Page MenuHomePhabricator
Create Task
Maniphest T175295

Fix layout issues on ULS (in Vector) to be closer aligned to WikimediaUI Style Guide
Closed, ResolvedPublic
Actions

Assigned To
Volker_E
Authored By
Volker_E
Sep 7 2017, 6:04 PM
Tags
Referenced Files
F15892038: image.png
Mar 20 2018, 2:15 AM
F10563545: T174237 ULS settings _before - Wikipedia 2017-09-06.png
Nov 2 2017, 5:23 AM
F10563543: T175295 Language settings dialog _post - Kazakhstan - Wikipedia 2017-11-01.png
Nov 2 2017, 5:23 AM
Subscribers
Aklapper
gerritbot
Nikerabbit
• Petar.petkovic
Pginer-WMF
• santhosh
Volker_E

Description

As a follow-up to T174237 we should also care about minor misalignments of ULS settings dialog.

  • Font-size of dialog (widgets) in Vector. We should aim for 14px base font-size equivalent, similar to OOUI in MW core – https://gerrit.wikimedia.org/r/387970
  • Headlines too light gray. We should aim for equivalence with Notifications/Alerts dialog
  • Box shadow too strong, let's go for standard box-shadow-dialog instead
  • Close icon not following WikimediaUI icon set. See also T50067
  • Confirmation buttons are too far left, using wider grid column should solve this – https://gerrit.wikimedia.org/r/387974
  • Putting Language settings headline a bit higher and closing the gap between close button row and contents
  • Vertical gaps on EN:WP due to style rules lurking into dialog
BeforeWith proposed patches applied
T174237 ULS settings _before - Wikipedia 2017-09-06.png (391×935 px, 89 KB)
T175295 Language settings dialog _post - Kazakhstan - Wikipedia 2017-11-01.png (618×1 px, 100 KB)

Details

SubjectRepoBranchLines +/-
Remove spacing to visually connect arbitrary separated partsmediawiki/extensions/UniversalLanguageSelectormaster+9 -3
Move “Language settings” dialog headline upmediawiki/extensions/UniversalLanguageSelectormaster+2 -2
Move buttons further to the side of dialogmediawiki/extensions/UniversalLanguageSelectormaster+2 -2
Introduce CSS class to enable lower specificity style overridesmediawiki/extensions/UniversalLanguageSelectormaster+2 -2
Follow core base font-size in Vectormediawiki/extensions/UniversalLanguageSelectormaster+5 -1
Align box shadow and colors to WikimediaUI Style Guidemediawiki/extensions/UniversalLanguageSelectormaster+17 -2
Use consistent close iconmediawiki/extensions/UniversalLanguageSelectormaster+9 -6
Customize query in gerrit

Related Objects

Event Timeline

Volker_E created this task.Sep 7 2017, 6:04 PM
Restricted Application added a project: UI-Standardization. · View Herald TranscriptSep 7 2017, 6:04 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Volker_E renamed this task from Fix minor layout issues on ULS to be aligned with WikimediaUI Style Guide to Fix minor layout issues on ULS to be closer aligned to WikimediaUI Style Guide.Sep 7 2017, 6:04 PM
Volker_E triaged this task as Medium priority.
Volker_E added a project: UniversalLanguageSelector.Sep 7 2017, 6:15 PM
gerritbot subscribed.Sep 7 2017, 11:55 PM

Change 376648 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/UniversalLanguageSelector@master] Use consistent close icon

https://gerrit.wikimedia.org/r/376648

gerritbot added a project: Patch-For-Review.Sep 7 2017, 11:55 PM
gerritbot added a comment.Sep 8 2017, 1:33 AM

Change 376656 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/UniversalLanguageSelector@master] Follow core base font-size in Vector

https://gerrit.wikimedia.org/r/376656

gerritbot added a comment.Sep 8 2017, 2:30 AM

Change 376659 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/UniversalLanguageSelector@master] Align box shadow and colors to WikimediaUI Style Guide

https://gerrit.wikimedia.org/r/376659

gerritbot added a comment.Sep 8 2017, 7:55 AM

Change 376648 merged by jenkins-bot:
[mediawiki/extensions/UniversalLanguageSelector@master] Use consistent close icon

https://gerrit.wikimedia.org/r/376648

gerritbot added a comment.Sep 8 2017, 9:00 AM

Change 376656 merged by jenkins-bot:
[mediawiki/extensions/UniversalLanguageSelector@master] Follow core base font-size in Vector

https://gerrit.wikimedia.org/r/376656

gerritbot added a comment.Sep 20 2017, 1:11 PM

Change 376659 merged by jenkins-bot:
[mediawiki/extensions/UniversalLanguageSelector@master] Align box shadow and colors to WikimediaUI Style Guide

https://gerrit.wikimedia.org/r/376659

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)).Sep 20 2017, 2:00 PM
Nikerabbit removed a project: Patch-For-Review.Sep 20 2017, 2:32 PM
Volker_E renamed this task from Fix minor layout issues on ULS to be closer aligned to WikimediaUI Style Guide to Fix minor layout issues on ULS (in Vector) to be closer aligned to WikimediaUI Style Guide.Sep 20 2017, 4:44 PM
Volker_E updated the task description. (Show Details)
Nikerabbit moved this task from Backlog to Performance and stability on the UniversalLanguageSelector board.Oct 13 2017, 9:29 AM
gerritbot added a comment.Nov 2 2017, 1:22 AM

Change 387970 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/UniversalLanguageSelector@master] Introduce CSS class to enable lower specificity style overrides

https://gerrit.wikimedia.org/r/387970

gerritbot added a project: Patch-For-Review.Nov 2 2017, 1:22 AM
gerritbot added a comment.Nov 2 2017, 3:07 AM

Change 387974 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/UniversalLanguageSelector@master] Move buttons further to the side of dialog

https://gerrit.wikimedia.org/r/387974

Volker_E updated the task description. (Show Details)Nov 2 2017, 3:11 AM
gerritbot added a comment.Nov 2 2017, 3:29 AM

Change 387975 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/UniversalLanguageSelector@master] Remove spacing to visually connect arbitrary separated parts

https://gerrit.wikimedia.org/r/387975

Volker_E updated the task description. (Show Details)Nov 2 2017, 5:09 AM
gerritbot added a comment.Nov 2 2017, 5:13 AM

Change 387976 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/UniversalLanguageSelector@master] Move “Language settings” dialog headline up

https://gerrit.wikimedia.org/r/387976

Volker_E renamed this task from Fix minor layout issues on ULS (in Vector) to be closer aligned to WikimediaUI Style Guide to Fix layout issues on ULS (in Vector) to be closer aligned to WikimediaUI Style Guide.Nov 2 2017, 5:23 AM
Volker_E raised the priority of this task from Medium to High.
Volker_E updated the task description. (Show Details)
Volker_E moved this task from Backlog to Review on the UI-Standardization-Kanban board.
gerritbot added a comment.Nov 2 2017, 6:12 AM

Change 387970 merged by jenkins-bot:
[mediawiki/extensions/UniversalLanguageSelector@master] Introduce CSS class to enable lower specificity style overrides

https://gerrit.wikimedia.org/r/387970

gerritbot added a comment.Nov 2 2017, 6:52 AM

Change 387974 merged by jenkins-bot:
[mediawiki/extensions/UniversalLanguageSelector@master] Move buttons further to the side of dialog

https://gerrit.wikimedia.org/r/387974

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)); removed MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)).Nov 2 2017, 7:01 AM
Amire80 moved this task from Performance and stability to Appearance and design on the UniversalLanguageSelector board.Nov 3 2017, 2:55 PM
gerritbot added a comment.Dec 1 2017, 5:29 AM

Change 387976 merged by jenkins-bot:
[mediawiki/extensions/UniversalLanguageSelector@master] Move “Language settings” dialog headline up

https://gerrit.wikimedia.org/r/387976

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)); removed MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)).Dec 1 2017, 6:00 AM
Amire80 added a project: Language-2018-Jan-Mar.Jan 2 2018, 1:58 PM
Arrbee moved this task from Backlog to In Review on the Language-2018-Jan-Mar board.Jan 5 2018, 1:09 PM
Volker_E updated the task description. (Show Details)Jan 26 2018, 6:43 PM
Volker_E removed a project: Wikimedia Design Style Guide.Jan 30 2018, 5:45 PM
Pginer-WMF added a comment.Mar 6 2018, 10:04 AM

@Volker_E, is there more work planned for this ticket from your side?

Nikerabbit moved this task from In Review to Blocked on the Language-2018-Jan-Mar board.Mar 8 2018, 7:45 AM
Arrbee moved this task from Blocked to Backlog on the Language-2018-Jan-Mar board.Mar 19 2018, 7:07 AM
Volker_E added a subscriber: • santhosh.Mar 20 2018, 2:15 AM

@Pginer-WMF On English Wikipedia there's still the vertical gaps resulting in “external“ CSS from Common.css. See discussion at https://gerrit.wikimedia.org/r/#/c/387975/1

image.png (628×1 px, 107 KB)

My latest understanding was that @santhosh looks into tackling this…

Volker_E reassigned this task from Volker_E to • santhosh.Mar 24 2018, 12:17 AM
Volker_E removed a project: Patch-For-Review.
Volker_E updated the task description. (Show Details)
• santhosh removed • santhosh as the assignee of this task.Mar 26 2018, 3:49 AM

We are not planning to look into this for now since we are focussed on some other projects. So unassigning for now.

Volker_E moved this task from Unsorted to Layout/pattern consistency on the UI-Standardization board.Mar 31 2018, 3:30 AM
Nikerabbit added a comment.Apr 21 2021, 1:29 PM

In the meanwhile, it looks like enwiki has changed styles not to target the columns class. Can someone confirm?

gerritbot added a comment.Apr 21 2021, 1:29 PM

Change 387975 abandoned by Nikerabbit:

[mediawiki/extensions/UniversalLanguageSelector@master] Remove spacing to visually connect arbitrary separated parts

Reason:

https://gerrit.wikimedia.org/r/387975

Volker_E closed this task as Resolved.Feb 5 2024, 3:55 PM
Volker_E claimed this task.

Ignoring the whitespace template issue here and putting this old task on resolved.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL