Page MenuHomePhabricator

[BUG] Exclude article theme picker circles from smart invert even when theme selection is default or sepia
Closed, InvalidPublic

Description

How many times were you able to reproduce it?

Always

Steps to reproduce

  1. Enable smart invert
  2. load any article
  3. tap on the "tT" icon in article toolbar
  4. tap the normal or sepia circles (the left and center ones)

Expected results

The left and center circles should remain light and sepia color respectively

Actual results

They both look black

Screenshots

Left and center circle are black when default theme is selected:

Screen Shot 2017-09-07 at 2.57.12 PM.png (1×1 px, 859 KB)

Left and center circle are black when sepia theme is selected:
Screen Shot 2017-09-07 at 2.57.17 PM.png (1×1 px, 1 MB)

All three circles are correct when dark theme is selected:
Screen Shot 2017-09-07 at 2.57.24 PM.png (1×1 px, 1 MB)

Environments observed

App version:
5.7
OS versions:
11
Device model:
iPad (bug probably all)
Device language:
EN

Regression?

NO

Event Timeline

Per @JMinor hold off on this ticket for the moment.

Apply smart invert across all themes (including dark mode) this is similar to iBooks on iOS11