Page MenuHomePhabricator

Switch to using headless section transform and attachment
Closed, ResolvedPublic

Description

This is as a result of the reasons outlined here:

https://phabricator.wikimedia.org/T174711

Event Timeline

Testing criteria

This ticket changed some of the under-the-hood mechanics of article presentation.
In general be on the lookout for any article loading regressions.
Specifically, it would be good to test the following:

Article loading and presentation:

  • Load an article like 'Barack Obama'
  • Load the same article on another device using the previous (app store) version
  • Make note of any loading regressions
  • Make note of any presentation regressions - scroll through the entire article on each device ensuring the articles look the same
  • Repeat the steps above with some other articles

Links:

  • Test tapping links on an article on the new version and on another device running the app store version
  • Ensure the new version link tapping works like the old version

Saved pages:

  • Save some articles
  • Put the device in airplane mode
  • Ensure the articles still load when tapped from the "Save pages" list

Testing on:
iPhone 7 (iOS 10.3.2) - Wikipedia app 5.7.1 (1259), app store version (left)
iPhone 6 Plus (iOS 11.1.2) - Wikipedia app 5.8.0 (1265). (right)

"Barack Obama" tests, link tests, and testing saving pages in airplane mode seemed to work as expected. For further evidence I attached images and videos below of another article I tested - "Continental Drift" - notice that the animated video plays the same in both apps on both devices.

T175320 Device Specs.JPG (3×4 px, 2 MB)
T175320 Article Comparison.JPG (3×4 px, 1 MB)

@Nicholas.tsg

"Barack Obama" tests, link tests, and testing saving pages in airplane mode seemed to work as expected. For further evidence I attached images and videos below of another article I tested - "Continental Drift" - notice that the animated video plays the same in both apps on both devices.

That's great! Thank you for the videos :)

ABorbaWMF subscribed.

It is also looking good to me on 5.8.0 (1265)

JMinor awarded a token.
JMinor subscribed.

I wanted to find some funny "headless" gif, but couldn't find anything SFW...