Page MenuHomePhabricator
Create Task
Maniphest T175417

VE table columns editing is destroyed in RTL
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Hi. When editing tables in VE, RTL only, many browsers, the right location for column top sections is destroyed.
For example,

Untitled.png (117×1 px, 7 KB)

choosing with the mouse the second from the left column, shows the column "arrow" in the middle of the sidebar. The rows are OK.
It wasn't like this before, for sure.

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (f88cd00a6)mediawiki/extensions/VisualEditormaster+20 -1
ui.TableLineContext: adjust positioningVisualEditor/VisualEditormaster+1 -2
Customize query in gerrit

Related Objects

Event Timeline

IKhitron created this task.Sep 8 2017, 8:19 PM
Restricted Application added a project: I18n. · View Herald TranscriptSep 8 2017, 8:19 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Esanders subscribed.Sep 8 2017, 10:19 PM

Bisect blames https://gerrit.wikimedia.org/r/#/c/363619/1

• Deskana triaged this task as High priority.Sep 11 2017, 11:33 AM
• Deskana moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Esanders added a subscriber: DLynch.Sep 11 2017, 9:18 PM

Pinging @DLynch

DLynch added a comment.Sep 11 2017, 9:19 PM

...huh. I'll take a look.

gerritbot subscribed.Sep 12 2017, 2:58 PM

Change 377482 had a related patch set uploaded (by DLynch; owner: DLynch):
[VisualEditor/VisualEditor@master] ui.TableLineContext: adjust positioning

https://gerrit.wikimedia.org/r/377482

gerritbot added a project: Patch-For-Review.Sep 12 2017, 2:58 PM
gerritbot added a comment.Sep 12 2017, 3:43 PM

Change 377482 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] ui.TableLineContext: adjust positioning

https://gerrit.wikimedia.org/r/377482

gerritbot added a comment.Sep 12 2017, 4:29 PM

Change 376899 had a related patch set uploaded (by Jforrester; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (f88cd00a6)

https://gerrit.wikimedia.org/r/376899

gerritbot added a comment.Sep 12 2017, 5:49 PM

Change 376899 merged by Jforrester:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (f88cd00a6)

https://gerrit.wikimedia.org/r/376899

• Deskana closed this task as Resolved.Sep 12 2017, 6:25 PM
• Deskana assigned this task to DLynch.
• Deskana set the point value for this task to 1.
• Deskana subscribed.

Now I am become @DLynch, the un-destroyer of table editing.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptSep 12 2017, 6:25 PM
Jdforrester-WMF edited projects, added MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)); removed Patch-For-Review.Sep 13 2017, 3:35 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL