Page MenuHomePhabricator

Hits from private AbuseFilters aren't in the stream
Closed, InvalidPublic

Description

Is this intentional?

Is this documented anywhere?

Is this configurable?

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Hey @Nirmos can you provide a bit more context on this?

Okay, so. I'm working on https://sv.wikipedia.org/wiki/MediaWiki:Gadget-EventStreams.js. It connects to https://stream.wikimedia.org/v2/stream/recentchange.

AbuseFilters can be made private, so that the rule set is not shown to non-admins.

After a lot of testing, I discovered that hits from private AbuseFilters aren't in the stream.

Hi @Nirmos, I'm not super familiar with the AbuseFilters. Can you please give us an explanation of the flow that you are seeing and the one that you'd expect to see? Thanks!

When someone trips a public filter, I get a JSON blob like this:

{
    "bot":false,
    "comment":"",
    "id":null,
    "log_action":"hit",
    "log_action_comment":"213.89.20.21 utlöste [[Special:Missbruksfilter/39|filter 39]], utförde åtgärden \"edit\" på  [[Användardiskussion:Nirmostest]]. Åtgärder: ingen ([[Special:Missbrukslogg/544200|detaljer]])",
    "log_id":0,
    "log_params":{
        "action":"edit",
        "actions":"",
        "filter":39,
        "log":544200
    },
    "log_type":"abusefilter",
    "meta":{
        "domain":"sv.wikipedia.org",
        "dt":"2017-09-29T06:15:18+02:00",
        "id":"cd66a88c-a4cc-11e7-9234-141877613c2d",
        "request_id":"869ac87b-b638-4a83-afc2-e61a85d17789",
        "schema_uri":"mediawiki/recentchange/1",
        "topic":"eqiad.mediawiki.recentchange",
        "uri":"https://sv.wikipedia.org/wiki/Anv%C3%A4ndardiskussion:Nirmostest",
        "partition":0,
        "offset":448933816
    },
    "namespace":3,
    "parsedcomment":"",
    "server_name":"sv.wikipedia.org",
    "server_script_path":"/w",
    "server_url":"https://sv.wikipedia.org",
    "timestamp":1506658518,
    "title":"Användardiskussion:Nirmostest",
    "type":"log",
    "user":"213.89.20.21",
    "wiki":"svwiki"
}

However, if the filter that has been tripped is private, no such JSON blob is in the stream.

I expect to see a JSON blob in the stream even if the filter is private.

@Nirmos we'll be looking at this but it's possible that this behaviour is by design.

ping @Catrope: this seems normal, right, these changes wouldn't show up in Recent Changes? @Nirmos, do you see this showing up on the Recent Changes page? If so, then there's some problem, otherwise it's by design.

Milimetric moved this task from Wikistats to Backlog (Later) on the Analytics board.

Filter hits aren't in RecentChanges, regardless of whether the filter is private or not.

Sounds like the system is working as designed.