Page MenuHomePhabricator

Moving Minerva out of MobileFrontend creates confusing compatibility exception (empty branches)
Open, LowestPublic

Description

Branches REL1_29, REL1_28 and REL1_27 are empty directories.

Branch master is not compatible with MobileFrontend REL1_29 (exception MinervaNeue is not compatible with the current installed version of MobileFrontend (1.0.0), it requires: >= 2.0.0.).

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 9 2017, 3:31 AM
Aklapper added a comment.EditedSep 9 2017, 12:53 PM

@alex-mashin: That looks like two very different topics which should not be in one single task?

There is one topic here: empty branches. That master requires MobileFrontend 2.0 is not necessarily an error itself, it just makes using master branch instead of REL1_29 impossible.

Reedy updated the task description. (Show Details)Sep 10 2017, 9:58 AM
Reedy added a subscriber: Reedy.Sep 10 2017, 10:03 AM

https://github.com/wikimedia/mediawiki-skins-MinervaNeue/commits/master?after=c53790b09f5f305bfa9f44ae29dbb30f8f606a79+174

The repo was made December 2015, but not actually used until Jun 1, 2017.

Questionably REL1_2[789] should be deleted to stop confusion; they add no value.

But 1.29 was branched in April, https://github.com/wikimedia/mediawiki/commit/ed43d8c3285d18f4231b9a4efff4ada178f3d97d so there it shouldn't be presumed that MinervaNeue shouldn't work with REL1_29, as the code didn't exist at that time.

Is there any reason you can't just use the REL1_29 branch of MobileFrontend with REL1_29 of MediaWiki; which is the general version matching method that is suggested to be used?

Because REL1_29 of MinervaNeue is empty (see description), so there's only master, which also requires master branch of MobileFrontend (REL1_29 of MobileFrontend is 1.0.0 not 2.0.0, thus incompatible), and master version of MobileFrontend is incompatible with REL1_29 of MediaWiki

Jdlrobson triaged this task as Lowest priority.Sep 22 2017, 2:11 PM
Jdlrobson added a subscriber: Jdlrobson.

Yes this is related to us moving Minerva out of MobileFrontend. The error message is referring to MobileFrontend's branch.

The port from MobileFrontend to Minerva caused a lot of confused but I don't think it's possible to avoid it.

We can delete those branches if it helps avoid this confusion but I'm not planning on doing that or anything else. Things will be less confusing a few branches down the road.

Jdlrobson renamed this task from Empty branches to Moving Minerva out of MobileFrontend creates confusing compatibility exception (empty branches).Sep 22 2017, 2:12 PM
Jdlrobson moved this task from Backlog to New adventures on the MinervaNeue board.Sep 27 2017, 8:30 PM
Jdlrobson moved this task from New adventures to 3rd party support on the MinervaNeue board.
Jdlrobson edited projects, added MinervaNeue (3rd party support); removed MinervaNeue.