[BUG] API:Imageinfo returns null for &iiprop=comment
Closed, ResolvedPublic

Description

This (action=query&format=json&prop=imageinfo&titles=File%3AExample.jpg&iiprop=comment) Imageinfo API query on File:Example.jpg returns null for the comment value. The expected value for comment should be: Minor tweak to text placement; diminish image height by 1 pixel. This was working as expected until a few days ago, when presumably, something broke. Please investigate, thanks.

Fastily created this task.Sat, Sep 9, 5:58 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSat, Sep 9, 5:58 AM
Fastily renamed this task from API:Imageinfo returns null for &iiprop=comment to [BUG] API:Imageinfo returns null for &iiprop=comment.Sat, Sep 9, 6:11 AM
TTO added a subscriber: TTO.Sat, Sep 9, 7:14 AM

@Anomie has been doing some comment-related stuff recently...

TheDJ added a subscriber: TheDJ.EditedSat, Sep 9, 7:45 AM

Yeah, i'm guessing this bug is related to the epic reworking of how all the editsummaries are stored. T166732: Refactor comment storage in the database and abstract access in MediaWiki and T166733: Deploy refactored comment storage

Change 376880 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/core@master] LocalFile: Fix setting $this->description after CommentStore changes

https://gerrit.wikimedia.org/r/376880

I put together a patch that fixed the issue for me locally, and passes tests. How impactful is this API regression? Does it require an emergency deploy over the weekend or can it wait until Monday?

Restricted Application added projects: Commons, Multimedia. · View Herald TranscriptSat, Sep 9, 10:01 AM

See also T175444, it seems to affect also the file history page

Change 376915 had a related patch set uploaded (by Reedy; owner: Legoktm):
[mediawiki/core@wmf/1.30.0-wmf.17] LocalFile: Fix setting $this->description after CommentStore changes

https://gerrit.wikimedia.org/r/376915

Change 376880 merged by jenkins-bot:
[mediawiki/core@master] LocalFile: Fix setting $this->description after CommentStore changes

https://gerrit.wikimedia.org/r/376880

Change 376915 merged by jenkins-bot:
[mediawiki/core@wmf/1.30.0-wmf.17] LocalFile: Fix setting $this->description after CommentStore changes

https://gerrit.wikimedia.org/r/376915

Mentioned in SAL (#wikimedia-operations) [2017-09-09T20:41:45Z] <legoktm@tin> Synchronized php-1.30.0-wmf.17/includes/filerepo/file/LocalFile.php: Fix issues related to comments and files in UI and API - T175443 T175444 (duration: 00m 46s)

Legoktm closed this task as Resolved.Sat, Sep 9, 8:44 PM
Legoktm claimed this task.

This should be fixed now. Cached entries for images on Commons might take a while to invalidate though.