Page MenuHomePhabricator

Support suppression (oversight) of newsletters
Closed, ResolvedPublic

Description

Oversighters (and with those capabilities such as stewards and wmf staff) should be able to suppress newsletters or new newsletter issues. Please create a new right: newsletter-suppress with the capability of suppressing newsletters or individual newsletter issues, then have it assigned to oversighters.

As currently this is only on mediawiki.org and only administrators are able to use it the risk is low, but I consider this to be a blocker to further deployment to further Wikimedia sites until this is resolved. I expect some projects will also request new groups so non-admins be able to manage newsletters and we need to be sure that things can be suppressed in case things go wrong.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 9 2017, 12:55 PM
Bawolff added a subscriber: Bawolff.Sep 9 2017, 7:41 PM

Oversighters should already be able to do this. Is that not the case?

Oversighters should already be able to do this. Is that not the case?

Have not tested but there's no change in mediawiki's oversighter group permissions, nor the extension.json file shows any suppress related right.

Legoktm added a subscriber: Legoktm.Sep 9 2017, 8:17 PM

Oversighters should already be able to do this. Is that not the case?

Have not tested but there's no change in mediawiki's oversighter group permissions, nor the extension.json file shows any suppress related right.

Please test before filing bugs like this then? Newsletter is based on normal wiki pages, so the normal revision deletion and suppression methods should just work. If not, then that's a bug.

Newsletter's can be oversighted, but suppressed titles of newsletters will continue to appear in logs, even if we suppress the whole newsletter. This does not happen with normal wiki pages, whose titles are also removed from logs.

https://test.wikipedia.org/w/index.php?title=Special%3ALog&type=newsletter&user=&page=Special%3ANewsletter%2F11&year=&month=-1&tagfilter=&subtype=

That is a bug.

Is that actually correct? I was under the impression for normal pages, the deletion log entry gets suppressed but not any other log entries (e.g. for an image the upload log entry does not get automatically suppressed)

https://test.wikipedia.org/w/index.php?title=Special%3ALog&type=move&user=&page=OS-T1&year=&month=-1&tagfilter=&subtype= displays that you're correct that you've to chase titles in logs as well (OS-T2 title is suppressed).

I do not remember we had to do that in the past.

@Risker Do you have better memory as if title suppression did removed in the past the page title as well from related logs? I know hideuser does, but I cannot remember if page suppression did as well.

QuimGil triaged this task as Low priority.Sep 9 2017, 9:30 PM
QuimGil moved this task from Backlog to Needs discussion on the MediaWiki-extensions-Newsletter board.

@Risker Do you have better memory as if title suppression did removed in the past the page title as well from related logs? I know hideuser does, but I cannot remember if page suppression did as well.

Page titles have never been automatically suppressed from logs, as far as I know, even when deleted or deletion-suppressed. I haven't recently had to deletion-suppress a page or delete a page because of its title, so I've not had to go through the process of looking through the logs for a while. But on those occasions when the title is itself a reason for suppression, we have had to go through a bunch of logs to wipe it all out. I seem to recall enwiki's team complaining about this way back when revision-deletion and suppression were first initiated in 2009, and it's one "bug" that never got fixed to my knowledge.

Bawolff closed this task as Resolved.Sep 27 2017, 3:06 AM
Bawolff claimed this task.

With that in mind im going to close this bug. Having revdel kill all the logs automatically sounds like a very reasonable feature request, but its not a newsletter issue.

@Risker and @Bawolff Thanks both. I'll file a task for doDeleteArticle with $suppress to also remove the page title from logs as it's done with hideuser blocks.