Page MenuHomePhabricator

The star icon will not show/load in Quarry's star button
Closed, ResolvedPublic

Description

8fffd37 Dropped bootstrap CSS and I suspect the font uris, which are relative to bootwatch's, no longer work as a result. Bootstrap was providing the fallback.

Event Timeline

Change 377043 had a related patch set uploaded (by Ricordisamoa; owner: Ricordisamoa):
[analytics/quarry/web@master] Load Glyphicons Halflings from cdnjs

https://gerrit.wikimedia.org/r/377043

Change 377043 merged by jenkins-bot:
[analytics/quarry/web@master] Load Glyphicons Halflings from cdnjs

https://gerrit.wikimedia.org/r/377043

Mentioned in SAL (#wikimedia-cloud) [2017-09-10T16:22:21Z] <zhuyifei1999_> Deployed a6173a2 on quarry-main-01 T175466

I tested the bad commit with one of my own queries while logged in so the star button wasn't there and the browser didn't even try to load the icon font...

IIRC, you can't star your own query...