Page MenuHomePhabricator

Fields of newsletter not being updated in the newsletter info page
Open, NormalPublic

Description

https://www.mediawiki.org/wiki/Newsletter:Newsletter%C2%B2 is displaying old information. Alt-reload in my browser, `?action=purge` or a "null edit" don't seem to do anything.

I updated the description of Newsletter², and the new version appears correctly in the list of newsletters and the Manage page:

However, the info page still has the old description.

In fact, the info page shows only Qgil-WMF as publisher, when in fact QuimGil is a publisher as well. The Manage page lists both and user QuimGil clearly has publisher permissions.

Details

Related Gerrit Patches:
mediawiki/extensions/Newsletter : masterFix inconsistent Newsletter permission checking
mediawiki/extensions/Newsletter : masterFix error handling and abuse filter integration during edit

Event Timeline

QuimGil created this task.Sep 10 2017, 8:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 10 2017, 8:18 PM
QuimGil triaged this task as Normal priority.Sep 10 2017, 8:19 PM

Thank you @MarcoAurelio for finding this bug.

@QuimGil This has been de penalti as we'd say. What I noticed was T175280 but that uncovered this as well :)

Glad to have helped, even unintentionally :)

I suspect but am not sure that this is related to the same root cause as T132022

This is weird. Today I saw that the old description had reappeared in Special:Newsletters and the Manage page. What / who brought it back and from where, I don't know.

I have updated the description again, and now it appears in Special:Newsletters and the Manage page again. https://www.mediawiki.org/wiki/Newsletter:Newsletter%C2%B2 keeps having the old description, like before.

I suspect but am not sure that this is related to the same root cause as T132022

Do you mean that AbuseFilter integration is currently half way, not completed?

Do you mean that AbuseFilter integration is currently half way, not completed?

The abusefilter is not working due to multiple overlapping save codepaths, and the abusefilter is only stopping some of them. Similarly i suspect this issue is caused by overlapping save paths, which cause inconsistencies.

Krinkle removed a subscriber: Krinkle.Sep 21 2017, 9:26 PM

Probably caused to our APIEdit stuff, which is kind of fixed one of these days. Can someone confirm this is happening now ?

Change 446642 had a related patch set uploaded (by Pppery; owner: Pppery):
[mediawiki/extensions/Newsletter@master] Fix inconsistent Newsletter permission checking

https://gerrit.wikimedia.org/r/446642

I ran into this just now. The newsletter remains unchanged even after updating the description and publishers. I see the updated content when I click the 'Manage' button but it shows the old content on the newsletter page itself.

Updated content in Manage tab:

I've tried modifying and saving a few times but it doesn't fix it.

@Niharika can you also point on which wiki this is happening ? Probably it was from a previous version I guess - but cant say without taking a good look. Thanks.

Pppery claimed this task.Sep 19 2018, 2:56 PM

Change 371743 had a related patch set uploaded (by Pppery; owner: Brian Wolff):
[mediawiki/extensions/Newsletter@master] Fix error handling and abuse filter integration during edit

https://gerrit.wikimedia.org/r/371743