Page MenuHomePhabricator
Create Task
Maniphest T175497

Fields of newsletter not being updated in the newsletter info page
Closed, ResolvedPublic
Actions

Description

https://www.mediawiki.org/wiki/Newsletter:Newsletter%C2%B2 is displaying old information. Alt-reload in my browser, `?action=purge` or a "null edit" don't seem to do anything.

I updated the description of Newsletter², and the new version appears correctly in the list of newsletters and the Manage page:

However, the info page still has the old description.

In fact, the info page shows only Qgil-WMF as publisher, when in fact QuimGil is a publisher as well. The Manage page lists both and user QuimGil clearly has publisher permissions.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Fix error handling and abuse filter integration during editPpperymediawiki/extensions/Newslettermaster+77 -68
Fix error handling and abuse filter integration during editBrian Wolffmediawiki/extensions/Newslettermaster+42 -48
Customize query in gerrit

Related Objects

Event Timeline

QuimGil created this task.Sep 10 2017, 8:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 10 2017, 8:18 PM
QuimGil triaged this task as Medium priority.Sep 10 2017, 8:19 PM
QuimGil added a subscriber: MarcoAurelio.Sep 10 2017, 8:27 PM

Thank you @MarcoAurelio for finding this bug.

MarcoAurelio added a comment.Sep 10 2017, 8:40 PM

@QuimGil This has been de penalti as we'd say. What I noticed was T175280 but that uncovered this as well :)

Glad to have helped, even unintentionally :)

Bawolff subscribed.Sep 10 2017, 9:29 PM

I suspect but am not sure that this is related to the same root cause as T132022

IKhitron subscribed.Sep 10 2017, 9:32 PM
QuimGil added a comment.Sep 11 2017, 9:31 AM

This is weird. Today I saw that the old description had reappeared in Special:Newsletters and the Manage page. What / who brought it back and from where, I don't know.

I have updated the description again, and now it appears in Special:Newsletters and the Manage page again. https://www.mediawiki.org/wiki/Newsletter:Newsletter%C2%B2 keeps having the old description, like before.

In T175497#3595142, @Bawolff wrote:

I suspect but am not sure that this is related to the same root cause as T132022

Do you mean that AbuseFilter integration is currently half way, not completed?

QuimGil merged a task: T176435: Description for Newsletter² stuck .Sep 21 2017, 9:03 PM
QuimGil added a subscriber: Krinkle.
Bawolff added a comment.Sep 21 2017, 9:19 PM

Do you mean that AbuseFilter integration is currently half way, not completed?

The abusefilter is not working due to multiple overlapping save codepaths, and the abusefilter is only stopping some of them. Similarly i suspect this issue is caused by overlapping save paths, which cause inconsistencies.

Krinkle unsubscribed.Sep 21 2017, 9:26 PM
01tonythomas subscribed.Nov 4 2017, 2:44 PM

Probably caused to our APIEdit stuff, which is kind of fixed one of these days. Can someone confirm this is happening now ?

QuimGil mentioned this in T187832: Trying to update the list of publishers resulted in me doing vandalism instead.Feb 20 2018, 9:59 PM
Quiddity mentioned this in T188139: Updating the list of Newsletter publishers is not recorded in page history.Feb 23 2018, 9:06 PM
gerritbot subscribed.Jul 18 2018, 8:01 PM

Change 446642 had a related patch set uploaded (by Pppery; owner: Pppery):
[mediawiki/extensions/Newsletter@master] Fix inconsistent Newsletter permission checking

https://gerrit.wikimedia.org/r/446642

gerritbot added a project: Patch-For-Review.Jul 18 2018, 8:01 PM
• Niharika subscribed.Jul 28 2018, 1:21 AM

I ran into this just now. The newsletter remains unchanged even after updating the description and publishers. I see the updated content when I click the 'Manage' button but it shows the old content on the newsletter page itself.

image.png (1,302×1,044 px, 161 KB)

Updated content in Manage tab:

image.png (1,546×968 px, 149 KB)

I've tried modifying and saving a few times but it doesn't fix it.

01tonythomas added a comment.Jul 28 2018, 8:24 AM

@Niharika can you also point on which wiki this is happening ? Probably it was from a previous version I guess - but cant say without taking a good look. Thanks.

• Niharika added a comment.Jul 28 2018, 4:10 PM

@01tonythomas On Mediawiki.org.

Pppery claimed this task.Sep 19 2018, 2:56 PM
gerritbot added a comment.Sep 19 2018, 3:00 PM

Change 371743 had a related patch set uploaded (by Pppery; owner: Brian Wolff):
[mediawiki/extensions/Newsletter@master] Fix error handling and abuse filter integration during edit

https://gerrit.wikimedia.org/r/371743

gerritbot added a comment.Dec 3 2019, 10:18 PM

Change 446642 had a related patch set uploaded (by Pppery; owner: Pppery):
[mediawiki/extensions/Newsletter@master] Fix inconsistent Newsletter permission checking

https://gerrit.wikimedia.org/r/446642

gerritbot added a comment.Aug 13 2022, 6:00 PM

Change 446642 abandoned by Pppery:

[mediawiki/extensions/Newsletter@master] Fix inconsistent Newsletter permission checking

Reason:

Abandoning old unreviewed patches of mine that aren't particularly important.

https://gerrit.wikimedia.org/r/446642

Pppery removed Pppery as the assignee of this task.Aug 13 2022, 6:02 PM
Pppery removed a project: Patch-For-Review.
Pppery subscribed.
Pppery unsubscribed.
gerritbot added a comment.Mar 25 2023, 9:23 PM

Change 446642 restored by Pppery:

[mediawiki/extensions/Newsletter@master] Fix inconsistent Newsletter permission checking

https://gerrit.wikimedia.org/r/446642

gerritbot added a project: Patch-For-Review.Mar 25 2023, 9:23 PM
Pppery claimed this task.Mar 25 2023, 9:27 PM
gerritbot added a comment.Jun 24 2023, 5:58 PM

Change 446642 merged by jenkins-bot:

[mediawiki/extensions/Newsletter@master] Fix error handling and abuse filter integration during edit

https://gerrit.wikimedia.org/r/446642

Pppery closed this task as Resolved.Jun 24 2023, 6:18 PM
gerritbot added a comment.Jun 24 2023, 7:00 PM

Change 371743 abandoned by Majavah:

[mediawiki/extensions/Newsletter@master] Fix error handling and abuse filter integration during edit

Reason:

https://gerrit.wikimedia.org/r/371743

Pppery removed a project: Patch-For-Review.Jun 24 2023, 7:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits