Page MenuHomePhabricator

Use new beta feature logo in FileExporter
Closed, ResolvedPublic

Assigned To
Authored By
Addshore
Sep 11 2017, 12:02 PM
Referenced Files
F9821796: image.png
Sep 26 2017, 3:23 PM
F9814510: image.png
Sep 26 2017, 8:38 AM
F9791664: betaIcon.svg
Sep 25 2017, 7:53 AM
F9724016: image.png
Sep 22 2017, 12:32 PM
F9165234: newtry.png
Sep 21 2017, 4:14 PM
F9173810: newtry.svg
Sep 21 2017, 11:42 AM
F9173811: wiki-agnostic(copy).svg
Sep 21 2017, 11:42 AM

Description

Beta feature images have been created in T169051 and should be used by the extension.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

@Addshore in T169051 there are two images. Do you know which one should be the new beta-feature logo? The F9173810 or F9173811 ?

Let's go with the one looking like

newtry.png (162×264 px, 6 KB)

being named "Newtry"

Change 379571 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[mediawiki/extensions/FileExporter@master] Add BetaFeatures preview image

https://gerrit.wikimedia.org/r/379571

I didnt realise how big this was going to turn out :/

image.png (820×1 px, 72 KB)

I'm not sure the betafeature logos generally stray from "regular" dimensions.

Thoughts?

oopsie. Yes, it ditched the crop that it had. Let me fix this…

Something still doesn't look right.

image.png (805×1 px, 68 KB)

Just for the record:
This happened only with Chrome/Blink-Engine browsers and I fixed it by removing the viewport argument in the SVG. See https://gerrit.wikimedia.org/r/#/c/379571/2..4/resources/FileExporter-beta-features.svg

Ok last comment, it seems to be more correct to add width and height then just removing the viewbox ^^' https://gerrit.wikimedia.org/r/#/c/379571/4..5/resources/FileExporter-beta-features.svg

I don't think the background of the SVG should be transparent, it should be white

image.png (364×289 px, 11 KB)

@Jan_Dittrich WMDE-Design

Change 379571 merged by jenkins-bot:
[mediawiki/extensions/FileExporter@master] Add BetaFeatures preview image

https://gerrit.wikimedia.org/r/379571