Change "Total applications (all time)" to "Accounts distributed", and instead of total applications, show e.g. "15/50". 15 is the number of valid authorizations, and 50 is the total number of available accounts. If we have no accounts_available data set, just show "15".

@Samwalton9 and how do we plan to handle partners with collections with non-empty accounts_available field?

And I guess my other question is, when we say 'valid' authorizations, do we mean authorizations that are active (non-empty date_expires and date >= today)? If so, what about authorizations with an empty date_expires field?

how do we plan to handle partners with collections with non-empty accounts_available field?

I'd be tempted to just handle it purely based on the partner accounts_available. As such, if we have individual collections with accounts_available, we ignore that and just show the current running total. I'm hesitant to over-engineer when we should prioritise T236676 as the more comprehensive fix. "Keep the per-collection numbers, but have them show active authorizations per-collection instead" is good enough for the time being I think.

when we say 'valid' authorizations, do we mean authorizations that are active (non-empty date_expires and date >= today)? If so, what about authorizations with an empty date_expires field?

I mean .is_valid(), which should cover this.

https://github.com/WikipediaLibrary/TWLight/pull/340

Can be tested on staging.

It occurs to me that we're also removing CSV download buttons here. That means there's a bunch of CSV URLs we can remove wholesale, and then we just need to extract the partner specific parts of the CSV download views, leaving the rest intact for the metrics page.

source