Page MenuHomePhabricator

Re-work partner page metrics
Closed, ResolvedPublic

Description

On partner pages (e.g. https://wikipedialibrary.wmflabs.org/partners/24/) we currently show Total applications and Total unique applicants. Let's show more useful data on the number of users who received access and the total number of distributed accounts.

  • Change "Total unique applicants (all time)" to "Users who received access (all time)", and instead of showing the figure for total unique users with any application, show total number of authorizations (incl. expired).
  • Change "Total applications (all time)" to "Accounts distributed", and instead of total applications, show e.g. "15/50". 15 is the number of valid authorizations, and 50 is the total number of available accounts. If we have no accounts_available data set, just show "15".
  • Additionally, for all partner pages, we can remove all the graphs in the metrics section. They're not useful to anyone. The Metrics heading can go too. (see T218868)
  • Keep the per-collection numbers, but have them show active authorizations per-collection instead.

For bundle partners, we should get rid of the number boxes and metrics section entirely because it deals with applications, and is therefore meaningless.

These changes should be made for both proxy + non-proxy partners. We'll make attempts to sure up the number of total accounts available for non-proxy partners.

Event Timeline

This comment was removed by Samwalton9.
Samwalton9 renamed this task from For authentication-based partners, add information to partner pages on how many users are currently on the access whitelist to Re-work Total applications and Total unique applications metrics boxes.Oct 15 2019, 10:38 AM
Samwalton9 updated the task description. (Show Details)
Samwalton9 renamed this task from Re-work Total applications and Total unique applications metrics boxes to Re-work partner page metrics.Oct 24 2019, 10:39 AM
Samwalton9 updated the task description. (Show Details)

Change "Total applications (all time)" to "Accounts distributed", and instead of total applications, show e.g. "15/50". 15 is the number of valid authorizations, and 50 is the total number of available accounts. If we have no accounts_available data set, just show "15".

@Samwalton9 and how do we plan to handle partners with collections with non-empty accounts_available field?

And I guess my other question is, when we say 'valid' authorizations, do we mean authorizations that are active (non-empty date_expires and date >= today)? If so, what about authorizations with an empty date_expires field?

how do we plan to handle partners with collections with non-empty accounts_available field?

I'd be tempted to just handle it purely based on the partner accounts_available. As such, if we have individual collections with accounts_available, we ignore that and just show the current running total. I'm hesitant to over-engineer when we should prioritise T236676 as the more comprehensive fix. "Keep the per-collection numbers, but have them show active authorizations per-collection instead" is good enough for the time being I think.

when we say 'valid' authorizations, do we mean authorizations that are active (non-empty date_expires and date >= today)? If so, what about authorizations with an empty date_expires field?

I mean .is_valid(), which should cover this.

It occurs to me that we're also removing CSV download buttons here. That means there's a bunch of CSV URLs we can remove wholesale, and then we just need to extract the partner specific parts of the CSV download views, leaving the rest intact for the metrics page.

source