Page MenuHomePhabricator

Check “single value” and “multi value” constraints on qualifiers and references
Closed, ResolvedPublic

Description

This seems pretty straightforward, it’s just the implementation that’s slightly tricky. If we go with the “sibling snaks” solution (or whatever we call it) in T175562 and T175565, we can also use that for these constraint types (just count the sibling snaks).

Patch-For-Review:

Details

Related Gerrit Patches:
mediawiki/extensions/WikibaseQualityConstraints : masterRemove not needed Statements from Multi/SingleValueChecker tests
mediawiki/extensions/WikibaseQualityConstraints : masterSupport qualifier and reference in value count checkers
mediawiki/extensions/WikibaseQualityConstraints : masterRewrite ValueCountCheckerHelper

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 11 2017, 1:39 PM

Change 405033 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Rewrite ValueCountCheckerHelper

https://gerrit.wikimedia.org/r/405033

Change 405282 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Support qualifier and reference in value count checkers

https://gerrit.wikimedia.org/r/405282

Change 405875 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Remove not needed Statements from Multi/SingleValueChecker tests

https://gerrit.wikimedia.org/r/405875

Change 405033 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Rewrite ValueCountCheckerHelper

https://gerrit.wikimedia.org/r/405033

Change 405282 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Support qualifier and reference in value count checkers

https://gerrit.wikimedia.org/r/405282

Lucas_Werkmeister_WMDE closed this task as Resolved.Jan 23 2018, 5:26 PM

Change 405875 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Remove not needed Statements from Multi/SingleValueChecker tests

https://gerrit.wikimedia.org/r/405875