Page MenuHomePhabricator
Create Task
Maniphest T175586

Geo URIs are incorrectly loading
Closed, ResolvedPublic
Actions

Description

Testing Criteria:

  1. Go to Geo URI scheme - https://en.m.wikipedia.org/wiki/Geo_URI_scheme?wprov=sfla1
  2. Go to examples
  3. Click first example
  4. Get taken to https://en.m.wikipedia.org/geo%3A37.786971%2C-122.399677 not geo:37.786971,-122.399677

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Correctly handle links with non-http schemes.apps/android/wikipediamaster+21 -7
Customize query in gerrit

Event Timeline

ThePenultimateOne created this task.Sep 11 2017, 3:23 PM
Restricted Application added a project: Wikipedia-Android-App-Backlog. · View Herald TranscriptSep 11 2017, 3:23 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Dbrant claimed this task.Sep 13 2017, 1:50 PM
gerritbot subscribed.Sep 13 2017, 1:51 PM

Change 377759 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[apps/android/wikipedia@master] Correctly handle links with non-http schemes.

https://gerrit.wikimedia.org/r/377759

gerritbot added a project: Patch-For-Review.Sep 13 2017, 1:51 PM
gerritbot added a comment.Sep 13 2017, 2:37 PM

Change 377759 merged by jenkins-bot:
[apps/android/wikipedia@master] Correctly handle links with non-http schemes.

https://gerrit.wikimedia.org/r/377759

Dbrant moved this task from Needs Triage to Android-app-release-v2.7.21x-Enchilada on the Wikipedia-Android-App-Backlog board.Sep 15 2017, 2:10 PM
Dbrant edited projects, added Wikipedia-Android-App-Backlog (Android-app-release-v2.7.21x-Enchilada); removed Wikipedia-Android-App-Backlog.
Dbrant moved this task from To Do to QA Signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.21x-Enchilada) board.Sep 15 2017, 2:20 PM
ABorbaWMF moved this task from QA Signoff to Ready for Signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.21x-Enchilada) board.Oct 11 2017, 7:56 PM
ABorbaWMF subscribed.

Tested on Nexus 4 with Android 5.1.1 and Pixel with Android 8.0.0 on Alpha App 2.6.203-alpha-2017-10-11

Works on both google maps and earth.

Dbrant moved this task from Ready for Signoff to Done on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.21x-Enchilada) board.Oct 23 2017, 1:50 PM
Dbrant closed this task as Resolved.Oct 23 2017, 1:53 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits