Page MenuHomePhabricator

reverting patchsets results in gerrit not wrapping lines in commit message
Open, Needs TriagePublic

Description

Filing this task to report a bad behavior on gerrits part.

I had to recently revert a patchset, and the revert behavior caused a commit message line character limit error:

Original (no issues) patchset https://gerrit.wikimedia.org/r/#/c/377170/

Patchset to revert the above, introduced line wrap issues: https://gerrit.wikimedia.org/r/#/c/377297/

When the commit message window is filled out, it doesn't then line break the commit message as our CI checks require, and thus fails. The editor should be patched to line wrap commit messages properly.

Event Timeline

RobH created this task.Sep 11 2017, 5:06 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 11 2017, 5:06 PM
RobH added a subscriber: Paladox.Sep 11 2017, 5:07 PM

I found this error when reverting that patchset, and @Paladox helpfully advised I should file a task about it for potential upstream filing fix in Gerrit for review.

Filled upstream at https://bugs.chromium.org/p/gerrit/issues/detail?id=7190

I will see what needs doing and see how easy it is with js code.

Paladox moved this task from Backlog to Reported Upstream on the Upstream board.Sep 11 2017, 5:12 PM
Paladox moved this task from Bugs & stuff to PolyGerrit on the Gerrit board.Sep 28 2017, 9:24 PM

Polygerrit new revert dialog actually asks you to insert reasons now :)