Page MenuHomePhabricator

"Undo" doesn't work from mouse (Chrome/Linux)
Closed, ResolvedPublic1 Story Points

Description

Reported at https://www.mediawiki.org/wiki/Topic:Txgdu98kg0yt28gy by @Paucabot, who uses Google Chrome 58 64-bit with Ubuntu Linux

"Undo" works with the keyboard shortcut and with the button in the toolbar, but not by right-clicking with the mouse.

Event Timeline

Restricted Application added a project: VisualEditor. · View Herald TranscriptSep 11 2017, 9:31 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Right click is "Undo" in Ubuntu?!

Right click opens a context menu. The first option is "undo".

Unfortunately this doesn't fire a reliable event. In Chrome it looks like you get event.inputType = 'historyUndo' / 'historyRedo', but in FF you get nothing (and I imagine IE).

Change 377471 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Trigger proper undo/redo when inputType=historyUndo/Redo

https://gerrit.wikimedia.org/r/377471

Change 377471 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Trigger proper undo/redo when inputType=historyUndo/Redo

https://gerrit.wikimedia.org/r/377471

Deskana assigned this task to Esanders.Sep 12 2017, 3:42 PM
Deskana closed this task as Resolved.
Deskana set the point value for this task to 1.

Hopefully this fixes things. :-)

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptSep 12 2017, 3:42 PM

Thanks, Deskana. When will it be deployed or when will I be able to check if it works?

Thanks, Deskana. When will it be deployed or when will I be able to check if it works?

The Beta Cluster (https://en.wikipedia.beta.wmflabs.org) is updated to the latest code every 10 minutes or so, so you should be able to check there soon. Sometimes it takes a little longer than 10 minutes though, and sometimes that site breaks in strange or interesting ways due to being a beta environment, so a little patience may be required. :-)

Change 376899 had a related patch set uploaded (by Jforrester; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (f88cd00a6)

https://gerrit.wikimedia.org/r/376899

Change 376899 merged by Jforrester:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (f88cd00a6)

https://gerrit.wikimedia.org/r/376899

Esanders added a comment.EditedSep 12 2017, 6:50 PM

The patch will only work on the very latest versions of Chrome (>=60), and MobileSafari (10.1 with WebKit >603). On any other browser it is basically impossible to know that the user requested an 'undo'. So the best we can do (and we already do) is observe the change the system makes, and record the transaction.