Page MenuHomePhabricator

History tools not updating state in standalone demo
Closed, ResolvedPublic1 Story Points

Description

  1. Open standalone
  2. Type
  3. Observe undo is still disabled

This works by chance in MediaWiki because use a dummy surface while initialising and so the surfaceChange event gets triggered when the second 'real' surface gets setup.

Event Timeline

Esanders created this task.Sep 12 2017, 7:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 12 2017, 7:18 PM

Change 377535 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Follow-up Ifcc2e6f: Emit surfaceChange after tool setup

https://gerrit.wikimedia.org/r/377535

Jdforrester-WMF renamed this task from History tools no updating state in standalone demo to History tools not updating state in standalone demo.Sep 12 2017, 7:22 PM
Deskana assigned this task to Esanders.Sep 12 2017, 7:23 PM
Deskana triaged this task as Normal priority.
Deskana moved this task from To Triage to TR1: Releases on the VisualEditor board.
Deskana set the point value for this task to 1.

Change 377535 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Follow-up Ifcc2e6f: Emit surfaceChange after tool setup

https://gerrit.wikimedia.org/r/377535

Change 377766 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (7028f79aa)

https://gerrit.wikimedia.org/r/377766

Change 377766 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (7028f79aa)

https://gerrit.wikimedia.org/r/377766

Deskana closed this task as Resolved.Sep 13 2017, 3:51 PM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptSep 13 2017, 3:51 PM