Page MenuHomePhabricator

[BUG] Search field is clipped on iPhone X
Closed, ResolvedPublic

Description

How many times were you able to reproduce it?

Always

Steps to reproduce

  1. Open app to explore
  2. Tap Search

Expected results

Search field is in the safe area

Actual results

Search field is cut off

Screenshots

Simulator Screen Shot - iPhone X - 2017-09-12 at 16.38.32.png (2×1 px, 402 KB)

Proposed design solution

Extend the Safe area to include the search bar and padding above the search bar

Event Timeline

@JoeWalsh, is there anyway that we can increase the margin for the X without disrupting the layout for other devices? Or would it be best to increase our margins on all devices?

JMinor triaged this task as Medium priority.Sep 18 2017, 6:06 PM
JMinor moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.

@cmadeo yeah, we can fix the X without affecting the other devices here's the updated layout on a 6S:

Simulator Screen Shot - iPhone 6s - 2017-09-21 at 07.11.43.png (1×750 px, 40 KB)

on an X:

Simulator Screen Shot - iPhone X - 2017-09-21 at 07.12.51.png (2×1 px, 75 KB)