Page MenuHomePhabricator

Move New Filters opt-out preference to its own section on the page
Closed, ResolvedPublic

Description

T168376 enables RC page users to opt out of the New Filters UX. As the screenshot below demonstrates, there are number of reasons which make it desirable that this option not be simply one in a list of options. E.g., unlike the other options on the page, it changes virtually everything about the page; i.e., it operates on a different scale. Also, it includes a line of explanatory text that is confusing in the layout below.

Solution

Apparently, constraints in how the Preference pages work make it difficult to adjust the layout to display as was requested in T168376, with the opt-out set a little apart from the other choices. Roan therefore suggests that the easiest way to achieve a similar effect is to put this option in its own section, with its own section title. Please, therefore:

  • Add a new section with the following title: Opt out of improvements
  • Remove the option and explanatory text (described in T168376) and move them to this new section. They are its only contents.
  • Position this new section underneath the current "Advanced options" section but above Pending Changes.

see below

Related Objects

Event Timeline

Change 378713 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/core@master] Move New Filters opt-out preference to own section

https://gerrit.wikimedia.org/r/378713

Change 378713 merged by jenkins-bot:
[mediawiki/core@master] Move New Filters opt-out preference to own section

https://gerrit.wikimedia.org/r/378713

Checked the fix in betalabs - the option "Hide the improved version of Recent Changes" is in the separate section titled "Opt out". All of the functionality that was checked before works as expected.

QA Recommendation: Resolve

Change 378781 had a related patch set uploaded (by Catrope; owner: Petar.petkovic):
[mediawiki/core@wmf/1.30.0-wmf.18] Move New Filters opt-out preference to own section

https://gerrit.wikimedia.org/r/378781

jmatazzoni closed this task as Resolved.Sep 18 2017, 8:35 PM

Change 378781 abandoned by Catrope:
Move New Filters opt-out preference to own section

https://gerrit.wikimedia.org/r/378781

Change 378781 restored by Catrope:
Move New Filters opt-out preference to own section

https://gerrit.wikimedia.org/r/378781

Change 378781 merged by jenkins-bot:
[mediawiki/core@wmf/1.30.0-wmf.18] Move New Filters opt-out preference to own section

https://gerrit.wikimedia.org/r/378781

Mentioned in SAL (#wikimedia-operations) [2017-09-19T15:54:08Z] <catrope@tin> Finished scap: core, GuidedTour and WikimediaMessages patches for T176191, T167262 and T175765 (duration: 20m 32s)