Page MenuHomePhabricator

Add MinusX to MediaWiki extensions and PHP library repos
Closed, ResolvedPublic

Assigned To
None
Authored By
Legoktm
Sep 13 2017, 6:56 AM
Tokens
"Yellow Medal" token, awarded by OmkarJ."Orange Medal" token, awarded by Krinkle."Mountain of Wealth" token, awarded by xSavitar."Meh!" token, awarded by greg."Like" token, awarded by Jdforrester-WMF."Doubloon" token, awarded by Tgr."Meh!" token, awarded by Addshore.

Description

To improve our code quality and security, we want to reject non-executable files which have execute bits (basically marks that tell the operating system it can run this file) set via a build check. In Wikimedia we have a utility called MinusX for this. Related: T168659: Reject non-executable files with execute bits with a build check

So we need to add MinusX to most MediaWiki extensions and PHP library repositories.

https://gerrit.wikimedia.org/r/#/c/377710/ is an example change for MediaWiki's Scribunto extension which shows what needs to be done.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/FundraisingEmailUnsubscribemaster+7 -2
mediawiki/coremaster+15 -2
mediawiki/extensions/SkinPerPagemaster+7 -2
integration/configmaster+1 -1
mediawiki/extensions/BlueSpiceNamespaceManagermaster+5 -2
mediawiki/extensions/BlueSpiceInterWikiLinksmaster+5 -2
mediawiki/extensions/BlueSpicePermissionManagermaster+5 -2
mediawiki/extensions/MsWikiEditormaster+7 -2
mediawiki/extensions/PagesListmaster+12 -2
mediawiki/extensions/BlueSpiceReadersmaster+5 -2
integration/configmaster+21 -0
mediawiki/extensions/BlueSpiceUserPreferencesmaster+7 -2
mediawiki/extensions/BlueSpiceContextMenumaster+7 -2
mediawiki/extensions/BlueSpiceCountThingsmaster+7 -2
mediawiki/extensions/BlueSpicePagesVisitedmaster+7 -2
mediawiki/extensions/BlueSpicePageTemplatesmaster+7 -2
mediawiki/extensions/BlueSpiceEmoticonsmaster+7 -2
mediawiki/extensions/BlueSpiceDashboardsmaster+8 -2
mediawiki/extensions/TimelineTablemaster+6 -1
mediawiki/extensions/TimelineTablemaster+7 -2
mediawiki/extensions/SkinPerPagemaster+8 -2
mediawiki/extensions/TimelineTablemaster+3 -2
mediawiki/extensions/BlueSpiceBlogmaster+7 -2
mediawiki/extensions/BlueSpiceAvatarsmaster+7 -2
mediawiki/extensions/BlueSpiceArticleInfomaster+7 -2
mediawiki/extensions/BlueSpiceAuthorsmaster+7 -2
mediawiki/extensions/MsLinksmaster+7 -2
mediawiki/extensions/MsInsertmaster+7 -2
mediawiki/extensions/BlueSpiceConfigManagermaster+7 -2
mediawiki/extensions/BlueSpiceChecklistmaster+7 -2
mediawiki/extensions/TweetANewmaster+7 -2
mediawiki/extensions/BlueSpiceGroupManagermaster+7 -2
mediawiki/extensions/BlueSpiceExtendedStatisticsmaster+7 -2
mediawiki/extensions/TweetANewmaster+7 -2
mediawiki/extensions/PushToWatchmaster+7 -2
mediawiki/extensions/PdfExportmaster+26 -21
mediawiki/extensions/BlueSpiceSmartlistmaster+7 -2
mediawiki/extensions/BlueSpiceUserManagermaster+7 -2
mediawiki/extensions/BlogPagemaster+7 -2
mediawiki/extensions/Athenamaster+9 -4
mediawiki/extensions/InterwikiIntegrationmaster+7 -2
mediawiki/extensions/HAWelcomemaster+7 -2
mediawiki/skins/VectorV2master+8 -3
mediawiki/skins/WoOgLeShadesmaster+7 -2
mediawiki/extensions/MetaMastermaster+17 -12
mediawiki/extensions/MessageCommonsmaster+7 -2
mediawiki/skins/Refreshedmaster+5 -2
mediawiki/skins/Nostalgiamaster+8 -3
mediawiki/extensions/MsCatSelectmaster+19 -14
mediawiki/extensions/MediaWikiChatmaster+7 -2
mediawiki/extensions/GoogleDocTagmaster+7 -2
mediawiki/skins/Vectormaster+8 -3
mediawiki/skins/Timelessmaster+8 -3
mediawiki/skins/Modernmaster+8 -3
mediawiki/skins/MonoBookmaster+8 -3
mediawiki/extensions/CommunityTwittermaster+7 -2
mediawiki/extensions/CreateUserPagemaster+7 -2
mediawiki/skins/CologneBluemaster+8 -3
mediawiki/extensions/UserPageViewTrackermaster+9 -4
mediawiki/skins/MinervaNeuemaster+6 -3
mediawiki/skins/Metrolookmaster+8 -3
mediawiki/skins/Materialmaster+7 -2
mediawiki/skins/Examplemaster+7 -2
mediawiki/skins/BlueSkymaster+7 -2
mediawiki/skins/BlueSpiceSkinmaster+7 -2
mediawiki/skins/Athenamaster+5 -2
mediawiki/skins/apexmaster+7 -2
Show related patches Customize query in gerrit

Related Objects

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 401008 merged by Florianschmidtwelzow:
[mediawiki/extensions/BlueSpiceAvatars@master] Add minusx to composer.json

https://gerrit.wikimedia.org/r/401008

Change 401009 merged by Florianschmidtwelzow:
[mediawiki/extensions/BlueSpiceBlog@master] Add minusx to composer.json

https://gerrit.wikimedia.org/r/401009

Change 401084 had a related patch set uploaded (by OmkarJ; owner: OmkarJ):
[mediawiki/extensions/TimelineTable@master] Add minusx to composer.json

https://gerrit.wikimedia.org/r/401084

Change 401085 had a related patch set uploaded (by OmkarJ; owner: OmkarJ):
[mediawiki/extensions/SkinPerPage@master] Add minusx to composer.json

https://gerrit.wikimedia.org/r/401085

Change 401086 had a related patch set uploaded (by OmkarJ; owner: OmkarJ):
[mediawiki/extensions/TimelineTable@master] Add minusx to composer.json Change mode of TimelineTable.php to 100644

https://gerrit.wikimedia.org/r/401086

Change 401086 abandoned by Florianschmidtwelzow:
Add minusx to composer.json

https://gerrit.wikimedia.org/r/401086

Change 401369 had a related patch set uploaded (by OmkarJ; owner: OmkarJ):
[mediawiki/extensions/TimelineTable@master] add minusx support and change modes

https://gerrit.wikimedia.org/r/401369

Change 401370 had a related patch set uploaded (by OmkarJ; owner: OmkarJ):
[mediawiki/extensions/SkinPerPage@master] add minusx support and change mode

https://gerrit.wikimedia.org/r/401370

Change 401085 abandoned by OmkarJ:
Add minusx to composer.json

https://gerrit.wikimedia.org/r/401085

Change 401084 abandoned by OmkarJ:
Add minusx to composer.json

https://gerrit.wikimedia.org/r/401084

Change 401369 merged by jenkins-bot:
[mediawiki/extensions/TimelineTable@master] add minusx support and change modes

https://gerrit.wikimedia.org/r/401369

Change 401397 had a related patch set uploaded (by OmkarJ; owner: OmkarJ):
[mediawiki/extensions/BlueSpiceEmoticons@master] add minusx support and change mode

https://gerrit.wikimedia.org/r/401397

Change 401396 had a related patch set uploaded (by OmkarJ; owner: OmkarJ):
[mediawiki/extensions/BlueSpiceDashboards@master] add minusx support and change modes

https://gerrit.wikimedia.org/r/401396

Change 401396 merged by Florianschmidtwelzow:
[mediawiki/extensions/BlueSpiceDashboards@master] add minusx support

https://gerrit.wikimedia.org/r/401396

Change 401397 merged by Florianschmidtwelzow:
[mediawiki/extensions/BlueSpiceEmoticons@master] add minusx support

https://gerrit.wikimedia.org/r/401397

Change 401745 had a related patch set uploaded (by OmkarJ; owner: OmkarJ):
[mediawiki/extensions/BlueSpicePageTemplates@master] add minusx support to composer.json

https://gerrit.wikimedia.org/r/401745

Change 401749 had a related patch set uploaded (by OmkarJ; owner: OmkarJ):
[mediawiki/extensions/BlueSpicePagesVisited@master] add minusx support to composer.json

https://gerrit.wikimedia.org/r/401749

Change 401745 merged by Florianschmidtwelzow:
[mediawiki/extensions/BlueSpicePageTemplates@master] add minusx support to composer.json

https://gerrit.wikimedia.org/r/401745

Change 401749 merged by Florianschmidtwelzow:
[mediawiki/extensions/BlueSpicePagesVisited@master] add minusx support to composer.json

https://gerrit.wikimedia.org/r/401749

Change 401757 had a related patch set uploaded (by OmkarJ; owner: OmkarJ):
[mediawiki/extensions/BlueSpiceCountThings@master] add minusx support to composer.json

https://gerrit.wikimedia.org/r/401757

Change 401761 had a related patch set uploaded (by OmkarJ; owner: OmkarJ):
[mediawiki/extensions/BlueSpiceContextMenu@master] add minux support to composer.json

https://gerrit.wikimedia.org/r/401761

Change 401757 merged by Florianschmidtwelzow:
[mediawiki/extensions/BlueSpiceCountThings@master] add minusx support to composer.json

https://gerrit.wikimedia.org/r/401757

Change 401761 merged by Florianschmidtwelzow:
[mediawiki/extensions/BlueSpiceContextMenu@master] add minux support to composer.json

https://gerrit.wikimedia.org/r/401761

Change 402166 had a related patch set uploaded (by Ryan10145; owner: Ryan10145):
[mediawiki/core@master] Added Minus-X Support

https://gerrit.wikimedia.org/r/402166

Change 402167 had a related patch set uploaded (by Ryan10145; owner: Ryan10145):
[mediawiki/extensions/BlueSpiceUserPreferences@master] Added Minus-X Support

https://gerrit.wikimedia.org/r/402167

Change 403320 had a related patch set uploaded (by Divadsn; owner: Divadsn):
[mediawiki/extensions/BlueSpiceInterWikiLinks@master] Add minus-x to composer.json

https://gerrit.wikimedia.org/r/403320

Change 403321 had a related patch set uploaded (by Divadsn; owner: Divadsn):
[mediawiki/extensions/BlueSpiceNamespaceManager@master] Add minus-x to composer.json

https://gerrit.wikimedia.org/r/403321

Change 403325 had a related patch set uploaded (by Phantom42; owner: Phantom42):
[integration/config@master] Add BlueSpiceFoundation for BlueSpice extensions

https://gerrit.wikimedia.org/r/403325

Change 403363 had a related patch set uploaded (by Divadsn; owner: Divadsn):
[mediawiki/extensions/BlueSpicePermissionManager@master] Add minus-x to composer.json

https://gerrit.wikimedia.org/r/403363

Change 403364 had a related patch set uploaded (by Divadsn; owner: Divadsn):
[mediawiki/extensions/BlueSpiceReaders@master] Add minus-x to composer.json

https://gerrit.wikimedia.org/r/403364

Change 402167 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceUserPreferences@master] Added Minus-X Support

https://gerrit.wikimedia.org/r/402167

Change 403325 abandoned by Phantom42:
Add BlueSpiceFoundation dependency for BlueSpice extensions

https://gerrit.wikimedia.org/r/403325

Change 400101 merged by jenkins-bot:
[mediawiki/extensions/PagesList@master] Add minus-x to extension PagesList.

https://gerrit.wikimedia.org/r/400101

Change 403364 merged by Umherirrender:
[mediawiki/extensions/BlueSpiceReaders@master] Add minus-x to composer.json

https://gerrit.wikimedia.org/r/403364

Change 404401 had a related patch set uploaded (by Phantom42; owner: Phantom42):
[integration/config@master] Add WikiAdmin dependency for BlueSpiceInterWikiLinks extension

https://gerrit.wikimedia.org/r/404401

Change 400102 merged by jenkins-bot:
[mediawiki/extensions/MsWikiEditor@master] Add minus-x to extension MsWikiEditor

https://gerrit.wikimedia.org/r/400102

Change 403363 merged by Robert Vogel:
[mediawiki/extensions/BlueSpicePermissionManager@master] Add minus-x to composer.json

https://gerrit.wikimedia.org/r/403363

Change 403320 merged by Robert Vogel:
[mediawiki/extensions/BlueSpiceInterWikiLinks@master] Add minus-x to composer.json

https://gerrit.wikimedia.org/r/403320

Change 403321 merged by Robert Vogel:
[mediawiki/extensions/BlueSpiceNamespaceManager@master] Add minus-x to composer.json

https://gerrit.wikimedia.org/r/403321

Change 404401 abandoned by Phantom42:
Add WikiAdmin dependency for BlueSpiceInterWikiLinks extension

Reason:
Abandoning this, as the problem got resolved in T184583

https://gerrit.wikimedia.org/r/404401

Change 401370 merged by jenkins-bot:
[mediawiki/extensions/SkinPerPage@master] add minusx support and change mode

https://gerrit.wikimedia.org/r/401370

Umherirrender triaged this task as Medium priority.
Umherirrender updated the task description. (Show Details)

All extensions now have the MinusX (except some empty repos without composer.json)

Please create a new task for individual extensions, if something is missing.

Thanks for the work on this

Change 402166 merged by jenkins-bot:
[mediawiki/core@master] build: Run minus-x to check for executable files that shouldn't be

https://gerrit.wikimedia.org/r/402166

Change 399480 had a related patch set uploaded (by Umherirrender; owner: Rafid Aslam):
[mediawiki/extensions/FundraisingEmailUnsubscribe@master] Add minus-x to "composer test"

https://gerrit.wikimedia.org/r/399480

Change 399480 merged by jenkins-bot:
[mediawiki/extensions/FundraisingEmailUnsubscribe@master] Add minus-x to "composer test"

https://gerrit.wikimedia.org/r/399480