Page MenuHomePhabricator

Edit counter not counting edits
Closed, ResolvedPublic

Event Timeline

Matthewrbowker moved this task from Backlog to Working on the XTools board.
Matthewrbowker subscribed.

As the new and old XTools are demonstrating this behavior, I suspect either an algorithm issue or a database issue. XTools is not displaying any replag banners so that’s not an issue.

Will investigate further.

Appears to be a replag issue, as the Simple Counter is showing the banner stating 20 hours. This begs the question as to why the edit counter doesn’t show the replag banner...

Appears to be a replag issue, as the Simple Counter is showing the banner stating 20 hours. This begs the question as to why the edit counter doesn’t show the replag banner...

https://github.com/x-tools/xtools/blob/master/src/AppBundle/Twig/AppExtension.php#L451 evalutes to en.wikipedia.org in the above example, when we need to query for enwiki.

I also think we should only show the replag message on result pages, since it is project-specific and on the initial form the user may change the project to something other than enwiki. This would also mean we could rely on the Project object passed in from the controller, with which we can call getDatabaseName().

Bringing this a step further, you might consider adding getReplag() or something to the Project model. So then in base.html.twig, you just need to put {% if project.replag > getReplagThreshold() %} ...

I think we should show the replag on all pages, however; on non-result pages maybe show the status of all databases? Goodness knows we already have that data available to us...

As for the miss-evaluation, I'll have a patch later today that should fix that.

@Zoranzoki21 FYI after we've merged we still need to deploy a task, so it goes in the "Pending deployment" column on the XTools board. I appreciate you helping out but note that in general you should leave this sort of thing to those who manage the board. We're about to deploy though so I'm going to leave under "Complete" :)

@Zoranzoki21 FYI after we've merged we still need to deploy a task, so it goes in the "Pending deployment" column on the XTools board. I appreciate you helping out but note that in general you should leave this sort of thing to those who manage the board. We're about to deploy though so I'm going to leave under "Complete" :)

Ok