Page MenuHomePhabricator
Create Task
Maniphest T175852

Firefox throws an exception every time enter is pressed
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

node is null in ve.ce.LinearSelection line 157

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (0ec5fe55f)mediawiki/extensions/VisualEditormaster+1 -1
Setup slugs in TreeModifierVisualEditor/VisualEditorREL1_30+29 -0
Setup slugs in TreeModifierVisualEditor/VisualEditormaster+29 -0
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Sep 13 2017, 6:34 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 13 2017, 6:34 PM
Esanders triaged this task as High priority.Sep 13 2017, 6:50 PM

regression introduce in TreeModifier commit

Esanders added a project: Regression.Sep 13 2017, 6:50 PM
dchan added a comment.Sep 14 2017, 2:24 AM

The superficial reason for the exception is that ve.ce.LinearSelection#getNodeClientRectFromRange fails if the range lies in the middle of an empty <p></p>.

The deeper reason is that a <p></p> is being created without a chimera.

• Deskana moved this task from To Triage to TR0: Interrupt on the VisualEditor board.Sep 14 2017, 10:36 AM
gerritbot subscribed.Sep 16 2017, 10:02 AM

Change 378378 had a related patch set uploaded (by Divec; owner: Divec):
[VisualEditor/VisualEditor@master] Setup slugs in TreeModifier

https://gerrit.wikimedia.org/r/378378

gerritbot added a project: Patch-For-Review.Sep 16 2017, 10:02 AM
dchan mentioned this in T175943: [Regression wmf.18] Cannot add any image with VE in Firefox, VE crashes upon clicking on "Insert".Sep 19 2017, 1:46 AM
gerritbot added a comment.Sep 19 2017, 5:08 AM

Change 378378 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Setup slugs in TreeModifier

https://gerrit.wikimedia.org/r/378378

• Deskana merged a task: T176201: VisualEditor: TypeError: node is null.Sep 19 2017, 9:52 AM
• Deskana added a subscriber: Raymond.
gerritbot added a comment.Sep 20 2017, 8:39 PM

Change 379328 had a related patch set uploaded (by Jforrester; owner: Divec):
[VisualEditor/VisualEditor@REL1_30] Setup slugs in TreeModifier

https://gerrit.wikimedia.org/r/379328

gerritbot added a comment.Sep 20 2017, 8:43 PM

Change 379328 merged by jenkins-bot:
[VisualEditor/VisualEditor@REL1_30] Setup slugs in TreeModifier

https://gerrit.wikimedia.org/r/379328

gerritbot added a comment.Sep 21 2017, 4:00 PM

Change 379557 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (bd5da1725)

https://gerrit.wikimedia.org/r/379557

Arlolra mentioned this in T174774: Editing captions in Firefox is so unpredictable as to be useless.Sep 21 2017, 8:45 PM
Jdforrester-WMF closed this task as Resolved.Sep 25 2017, 3:09 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF set the point value for this task to 1.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptSep 25 2017, 3:09 PM
gerritbot added a comment.Sep 25 2017, 3:16 PM

Change 379557 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (0ec5fe55f)

https://gerrit.wikimedia.org/r/379557

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits